Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1783)

Issue 328790043: [plaso] Add an option to write pinfo.py output to a file (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by romaing
Modified:
6 years, 8 months ago
Reviewers:
Joachim Metz
CC:
jberggren, onager, kiddi, log2timeline-dev_googlegroups.com, aaronp
Visibility:
Public.

Description

[plaso] Add an option to write pinfo.py output to a file I'll need the options for e2e tests purposes.

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M plaso/cli/pinfo_tool.py View 1 4 chunks +14 lines, -0 lines 0 comments Download

Messages

Total messages: 8
romaing
6 years, 10 months ago (2017-06-28 13:36:12 UTC) #1
Joachim Metz
I opt to merge these changes after https://codereview.appspot.com/326740043/
6 years, 10 months ago (2017-06-28 19:08:22 UTC) #2
romaing
On 2017/06/28 19:08:22, Joachim Metz wrote: > I opt to merge these changes after https://codereview.appspot.com/326740043/ ...
6 years, 8 months ago (2017-08-03 15:57:52 UTC) #3
Joachim Metz
thx for the reminder where is the github PR for this (automated tests) and can ...
6 years, 8 months ago (2017-08-03 17:23:56 UTC) #4
romaing
Code updated.
6 years, 8 months ago (2017-08-04 09:23:46 UTC) #5
romaing
On 2017/08/03 17:23:56, Joachim Metz wrote: > thx for the reminder where is the github ...
6 years, 8 months ago (2017-08-04 09:25:35 UTC) #6
Joachim Metz
LGTM
6 years, 8 months ago (2017-08-04 12:05:40 UTC) #7
romaing
6 years, 8 months ago (2017-08-04 12:36:50 UTC) #8
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close output-for-pinfo
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b