Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(71)

Issue 328380044: Patch for GSOC Project : Framework for TCP Prague simulations in ns-3

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 1 day ago by Shravya
Modified:
1 week, 1 day ago
Reviewers:
tomh, n.p
CC:
ns-3-reviews_googlegroups.com, ns-developers_isi.edu
Visibility:
Public.

Description

Patch for GSOC Project : Framework for TCP Prague simulations in ns-3

Patch Set 1 #

Total comments: 12
Unified diffs Side-by-side diffs Delta from patch set Stats (+7848 lines, -115 lines) Patch
A examples/tcp/dctcp-example.cc View 1 chunk +266 lines, -0 lines 2 comments Download
M examples/tcp/wscript View 1 chunk +5 lines, -0 lines 0 comments Download
M src/internet/doc/tcp.rst View 5 chunks +213 lines, -3 lines 0 comments Download
M src/internet/model/ipv4-queue-disc-item.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/internet/model/ipv4-queue-disc-item.cc View 1 chunk +12 lines, -0 lines 1 comment Download
M src/internet/model/ipv6-queue-disc-item.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/internet/model/ipv6-queue-disc-item.cc View 1 chunk +11 lines, -0 lines 1 comment Download
M src/internet/model/tcp-congestion-ops.h View 3 chunks +32 lines, -4 lines 3 comments Download
M src/internet/model/tcp-congestion-ops.cc View 2 chunks +9 lines, -1 line 0 comments Download
A src/internet/model/tcp-dctcp.h View 1 chunk +155 lines, -0 lines 0 comments Download
A src/internet/model/tcp-dctcp.cc View 1 chunk +262 lines, -0 lines 0 comments Download
M src/internet/model/tcp-header.cc View 1 chunk +1 line, -1 line 1 comment Download
M src/internet/model/tcp-socket-base.h View 11 chunks +86 lines, -4 lines 4 comments Download
M src/internet/model/tcp-socket-base.cc View 52 chunks +470 lines, -60 lines 0 comments Download
A src/internet/test/tcp-dctcp-test.cc View 1 chunk +687 lines, -0 lines 0 comments Download
A src/internet/test/tcp-dual-queue-test.cc View 1 chunk +154 lines, -0 lines 0 comments Download
A src/internet/test/tcp-ecn-test.cc View 1 chunk +567 lines, -0 lines 0 comments Download
M src/internet/test/tcp-general-test.h View 1 chunk +8 lines, -0 lines 0 comments Download
M src/internet/test/tcp-general-test.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/internet/wscript View 3 chunks +5 lines, -0 lines 0 comments Download
A src/netanim/examples/bcube-animation.cc View 1 chunk +109 lines, -0 lines 0 comments Download
A src/netanim/examples/fat-tree-animation.cc View 1 chunk +106 lines, -0 lines 0 comments Download
M src/netanim/examples/wscript View 1 chunk +8 lines, -0 lines 0 comments Download
M src/network/utils/queue-item.h View 1 chunk +7 lines, -0 lines 0 comments Download
M src/network/utils/queue-item.cc View 1 chunk +6 lines, -0 lines 0 comments Download
A src/point-to-point-layout/doc/bcube.rst View 1 chunk +58 lines, -0 lines 0 comments Download
A src/point-to-point-layout/doc/fattree.rst View 1 chunk +46 lines, -0 lines 0 comments Download
A src/point-to-point-layout/model/point-to-point-bcube.h View 1 chunk +201 lines, -0 lines 0 comments Download
A src/point-to-point-layout/model/point-to-point-bcube.cc View 1 chunk +266 lines, -0 lines 0 comments Download
A src/point-to-point-layout/model/point-to-point-fat-tree.h View 1 chunk +265 lines, -0 lines 0 comments Download
A src/point-to-point-layout/model/point-to-point-fat-tree.cc View 1 chunk +421 lines, -0 lines 0 comments Download
M src/point-to-point-layout/wscript View 2 chunks +4 lines, -0 lines 0 comments Download
A src/traffic-control/doc/dual-q-coupled-pi-square.rst View 1 chunk +114 lines, -0 lines 0 comments Download
A src/traffic-control/doc/pi-square.rst View 1 chunk +94 lines, -0 lines 0 comments Download
M src/traffic-control/doc/red.rst View 2 chunks +104 lines, -1 line 0 comments Download
M src/traffic-control/examples/adaptive-red-tests.cc View 9 chunks +37 lines, -13 lines 0 comments Download
A src/traffic-control/examples/dual-q-coupled-pi-square-example.cc View 1 chunk +341 lines, -0 lines 0 comments Download
A src/traffic-control/examples/pi-square-example.cc View 1 chunk +357 lines, -0 lines 0 comments Download
M src/traffic-control/examples/red-tests.cc View 5 chunks +16 lines, -7 lines 0 comments Download
M src/traffic-control/examples/wscript View 1 chunk +7 lines, -0 lines 0 comments Download
A src/traffic-control/model/dual-q-coupled-pi-square-queue-disc.h View 1 chunk +197 lines, -0 lines 0 comments Download
A src/traffic-control/model/dual-q-coupled-pi-square-queue-disc.cc View 1 chunk +548 lines, -0 lines 0 comments Download
A src/traffic-control/model/pi-square-queue-disc.h View 1 chunk +206 lines, -0 lines 0 comments Download
A src/traffic-control/model/pi-square-queue-disc.cc View 1 chunk +485 lines, -0 lines 0 comments Download
A src/traffic-control/test/dual-q-coupled-pi-square-queue-disc-test-suite.cc View 1 chunk +368 lines, -0 lines 0 comments Download
M src/traffic-control/test/examples-to-run.py View 1 chunk +24 lines, -20 lines 0 comments Download
A src/traffic-control/test/pi-square-queue-disc-test-suite.cc View 1 chunk +474 lines, -0 lines 0 comments Download
M src/traffic-control/wscript View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 2
n.p
I am sorry to spam ns-developers, but I would like to have the input of ...
1 week, 2 days ago (2017-09-10 09:31:14 UTC) #1
tomh_tomh.org
1 week, 1 day ago (2017-09-10 22:29:17 UTC) #2

On 9/10/17 2:31 AM, natale.patriciello@gmail.com wrote:
> I am sorry to spam ns-developers, but I would like to have the input of
> everyone that maybe do not follow ns-3-reviews regularly.
>
> The code quality is high; there are small issues that can be easily
> solved. However, I have one big concern regarding the design. I am
> (unless sound explications are made) against the 'friend' keyword on the
> TcpSocketBase. The overall idea behind the interface between congestion
> control and TCP socket is that we should have a clear way to made the
> two communicate. By adding the friend keyword, we are just circumventing
> that idea, allowing the congestion control to do whatever with the
> socket.

I had a look at this code and it seems that there is only one method 
(SendEmptyPacket()) that cannot be accomplished using the existing 
public API of TcpSocketBase, so perhaps we could just figure out a 
suitable public API extension for that piece, and avoid the friend keyword.

- Tom
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted