Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(952)

Issue 328310043: ticket:13327 Fixing buffer overflow in NumberingSystem constructor. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months ago by sffc
Modified:
1 month, 3 weeks ago
CC:
nrunge
Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/
Visibility:
Public.

Description

ticket:13327 Fixing buffer overflow in NumberingSystem constructor.

Patch Set 1 #

Patch Set 2 : Improving unit test. #

Total comments: 7

Patch Set 3 : Addressing code review comments. #

Total comments: 2

Patch Set 4 : Addressing code review comments 2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M i18n/numsys.cpp View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download
M test/intltest/numfmtst.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M test/intltest/numfmtst.cpp View 1 2 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 10
sffc
3 months ago (2017-08-19 02:21:42 UTC) #1
sffc
Improving unit test.
3 months ago (2017-08-19 02:27:31 UTC) #2
andy.heninger
Mostly LGTM, although the test code could be simplified. If you patch this into our ...
2 months, 1 week ago (2017-09-08 17:52:09 UTC) #3
markus.icu
https://codereview.appspot.com/328310043/diff/20001/icu4c/source/test/intltest/numfmtst.cpp File icu4c/source/test/intltest/numfmtst.cpp (right): https://codereview.appspot.com/328310043/diff/20001/icu4c/source/test/intltest/numfmtst.cpp#newcode8741 icu4c/source/test/intltest/numfmtst.cpp:8741: for (int runId = 0; runId < 2; runId++) ...
2 months, 1 week ago (2017-09-11 23:05:00 UTC) #4
sffc
Addressing code review comments.
1 month, 3 weeks ago (2017-09-28 00:53:37 UTC) #5
sffc
https://codereview.appspot.com/328310043/diff/20001/icu4c/source/test/intltest/numfmtst.cpp File icu4c/source/test/intltest/numfmtst.cpp (right): https://codereview.appspot.com/328310043/diff/20001/icu4c/source/test/intltest/numfmtst.cpp#newcode8741 icu4c/source/test/intltest/numfmtst.cpp:8741: for (int runId = 0; runId < 2; runId++) ...
1 month, 3 weeks ago (2017-09-28 00:54:38 UTC) #6
andy.heninger
LGTM, except for the one comment. https://codereview.appspot.com/328310043/diff/40001/i18n/numsys.cpp File i18n/numsys.cpp (right): https://codereview.appspot.com/328310043/diff/40001/i18n/numsys.cpp#newcode18 i18n/numsys.cpp:18: #include <uassert.h> quotes, ...
1 month, 3 weeks ago (2017-09-28 00:59:05 UTC) #7
sffc
Addressing code review comments 2
1 month, 3 weeks ago (2017-09-28 01:00:13 UTC) #8
sffc
https://codereview.appspot.com/328310043/diff/40001/i18n/numsys.cpp File i18n/numsys.cpp (right): https://codereview.appspot.com/328310043/diff/40001/i18n/numsys.cpp#newcode18 i18n/numsys.cpp:18: #include <uassert.h> On 2017/09/28 00:59:05, andy.heninger wrote: > quotes, ...
1 month, 3 weeks ago (2017-09-28 01:00:20 UTC) #9
sffc
1 month, 3 weeks ago (2017-09-28 01:00:58 UTC) #10
Committed revision 40494.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4