Issue 328230043: [dfwinreg] Migrated from construct to dtfabric

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 328230043: [dfwinreg] Migrated from construct to dtfabric (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 8 months ago by Joachim Metz

Modified:
6 years, 3 months ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[dfwinreg] Migrated from construct to dtfabric

Patch Set 1 #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -32 lines)			Patch
M	appveyor.yml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	config/dpkg/control	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	config/travis/install.sh	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	dependencies.ini	View	2 chunks	+12 lines, -11 lines	0 comments	Download
M	dfwinreg/fake.py	View	3 chunks	+36 lines, -8 lines	2 comments	Download
M	requirements.txt	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	setup.cfg	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	utils/dependencies.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

onager

https://codereview.appspot.com/328230043/diff/1/dfwinreg/fake.py File dfwinreg/fake.py (right): https://codereview.appspot.com/328230043/diff/1/dfwinreg/fake.py#newcode310 dfwinreg/fake.py:310: _DATA_TYPE_FABRIC_DEFINITION = b'\n'.join([ I don't find this very readable. ...

6 years, 6 months ago (2017-10-19 23:34:06 UTC) #2

Joachim Metz

I'll have to look at what the deployment impact of this is.

6 years, 6 months ago (2017-10-20 05:06:58 UTC) #3

onager

LGTM, with the caveat that we need to re-examine how to ship dtfabric definitions as ...

6 years, 4 months ago (2017-12-27 13:32:26 UTC) #4

Joachim Metz

Tracking in https://github.com/libyal/dtfabric/issues/6

6 years, 3 months ago (2017-12-27 18:10:11 UTC) #5

Joachim Metz

6 years, 3 months ago (2017-12-27 18:11:53 UTC) #6

Joachim Metz

6 years, 3 months ago (2018-01-18 19:26:50 UTC) #7

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close dtfabric

Expand All Messages | Collapse All Messages