Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1543)

Issue 328230043: [dfwinreg] Migrated from construct to dtfabric (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 3 weeks ago by Joachim Metz
Modified:
1 month ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfwinreg] Migrated from construct to dtfabric

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -32 lines) Patch
M appveyor.yml View 1 chunk +1 line, -1 line 0 comments Download
M config/dpkg/control View 2 chunks +2 lines, -2 lines 0 comments Download
M config/travis/install.sh View 2 chunks +4 lines, -4 lines 0 comments Download
M dependencies.ini View 2 chunks +12 lines, -11 lines 0 comments Download
M dfwinreg/fake.py View 3 chunks +36 lines, -8 lines 2 comments Download
M requirements.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M setup.cfg View 2 chunks +4 lines, -3 lines 0 comments Download
M utils/dependencies.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7
Joachim Metz
6 months, 3 weeks ago (2017-08-05 18:57:44 UTC) #1
onager
https://codereview.appspot.com/328230043/diff/1/dfwinreg/fake.py File dfwinreg/fake.py (right): https://codereview.appspot.com/328230043/diff/1/dfwinreg/fake.py#newcode310 dfwinreg/fake.py:310: _DATA_TYPE_FABRIC_DEFINITION = b'\n'.join([ I don't find this very readable. ...
4 months ago (2017-10-19 23:34:06 UTC) #2
Joachim Metz
I'll have to look at what the deployment impact of this is.
4 months ago (2017-10-20 05:06:58 UTC) #3
onager
LGTM, with the caveat that we need to re-examine how to ship dtfabric definitions as ...
1 month, 3 weeks ago (2017-12-27 13:32:26 UTC) #4
Joachim Metz
Tracking in https://github.com/libyal/dtfabric/issues/6
1 month, 3 weeks ago (2017-12-27 18:10:11 UTC) #5
Joachim Metz
https://codereview.appspot.com/328230043/diff/1/dfwinreg/fake.py File dfwinreg/fake.py (right): https://codereview.appspot.com/328230043/diff/1/dfwinreg/fake.py#newcode310 dfwinreg/fake.py:310: _DATA_TYPE_FABRIC_DEFINITION = b'\n'.join([ keeping this for now tracking possible ...
1 month, 3 weeks ago (2017-12-27 18:11:53 UTC) #6
Joachim Metz
1 month ago (2018-01-18 19:26:50 UTC) #7
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: review.py close dtfabric
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d