Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(122)

Issue 328060043: ticket:12519 BreakIterator assignment not handling locales (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by andy.heninger
Modified:
6 years, 8 months ago
Reviewers:
markus.icu
Base URL:
svn+ssh://source.icu-project.org/repos/icu/trunk/
Visibility:
Public.

Description

First upload.

Patch Set 1 #

Total comments: 8

Patch Set 2 : Fixes from review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -19 lines) Patch
M icu4c/source/common/brkiter.cpp View 2 chunks +14 lines, -1 line 0 comments Download
M icu4c/source/common/rbbi.cpp View 2 chunks +8 lines, -3 lines 0 comments Download
M icu4c/source/common/unicode/brkiter.h View 8 chunks +10 lines, -14 lines 0 comments Download
M icu4c/source/test/intltest/rbbitst.h View 1 chunk +1 line, -0 lines 0 comments Download
M icu4c/source/test/intltest/rbbitst.cpp View 1 3 chunks +35 lines, -1 line 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/rbbi/RBBITest.java View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4
markus.icu
https://codereview.appspot.com/328060043/diff/1/icu4c/source/test/intltest/rbbitst.cpp File icu4c/source/test/intltest/rbbitst.cpp (right): https://codereview.appspot.com/328060043/diff/1/icu4c/source/test/intltest/rbbitst.cpp#newcode4802 icu4c/source/test/intltest/rbbitst.cpp:4802: if (Locale::getEnglish() != biEn->getLocale(ULOC_VALID_LOCALE, status)) { Please use assertEquals() ...
6 years, 8 months ago (2017-07-19 21:14:35 UTC) #1
andy.heninger
Fixes from review comments.
6 years, 8 months ago (2017-07-20 00:40:10 UTC) #2
andy.heninger
Fixes for previous comments https://codereview.appspot.com/328060043/diff/1/icu4c/source/test/intltest/rbbitst.cpp File icu4c/source/test/intltest/rbbitst.cpp (right): https://codereview.appspot.com/328060043/diff/1/icu4c/source/test/intltest/rbbitst.cpp#newcode4802 icu4c/source/test/intltest/rbbitst.cpp:4802: if (Locale::getEnglish() != biEn->getLocale(ULOC_VALID_LOCALE, status)) ...
6 years, 8 months ago (2017-07-20 00:41:31 UTC) #3
markus.icu
6 years, 8 months ago (2017-07-24 20:09:15 UTC) #4
LGTM

The test code looks much nicer :-)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b