Issue 328040044: [dfvfs] Made Unicode strings the default #204 and updated docstrings #182

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 328040044: [dfvfs] Made Unicode strings the default #204 and updated docstrings #182 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 9 months ago by Joachim Metz

Modified:
6 years, 9 months ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

[dfvfs] Made Unicode strings the default #204 and updated docstrings #182

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+512 lines, -471 lines)			Patch
M	dfvfs/helpers/fake_file_system_builder.py	View	6 chunks	+7 lines, -5 lines	0 comments	Download
M	dfvfs/helpers/file_system_searcher.py	View	11 chunks	+21 lines, -19 lines	0 comments	Download
M	dfvfs/helpers/source_scanner.py	View	22 chunks	+34 lines, -32 lines	0 comments	Download
M	dfvfs/helpers/text_file.py	View	8 chunks	+25 lines, -19 lines	0 comments	Download
M	dfvfs/helpers/volume_scanner.py	View	21 chunks	+47 lines, -45 lines	0 comments	Download
M	dfvfs/helpers/windows_path_resolver.py	View	10 chunks	+45 lines, -45 lines	0 comments	Download
M	dfvfs/lib/bde.py	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	dfvfs/lib/cpio.py	View	15 chunks	+104 lines, -100 lines	0 comments	Download
M	dfvfs/lib/definitions.py	View	3 chunks	+51 lines, -49 lines	0 comments	Download
M	dfvfs/lib/ewf.py	View	4 chunks	+27 lines, -25 lines	0 comments	Download
M	dfvfs/lib/fvde.py	View	2 chunks	+5 lines, -3 lines	0 comments	Download
M	dfvfs/lib/glob2regex.py	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	dfvfs/lib/lvm.py	View	1 chunk	+9 lines, -4 lines	0 comments	Download
M	dfvfs/lib/raw.py	View	15 chunks	+76 lines, -73 lines	0 comments	Download
M	dfvfs/lib/sqlite_database.py	View	6 chunks	+12 lines, -12 lines	0 comments	Download
M	dfvfs/lib/tsk_image.py	View	3 chunks	+10 lines, -8 lines	0 comments	Download
M	dfvfs/lib/tsk_partition.py	View	4 chunks	+26 lines, -25 lines	0 comments	Download
M	dfvfs/lib/vshadow.py	View	1 chunk	+6 lines, -4 lines	0 comments	Download

Total messages: 3

Joachim Metz

6 years, 9 months ago (2017-07-18 18:35:55 UTC) #3

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close unicode4