Issue 327880043: [dfvfs] Changes to replace stat with attributes #52

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 327880043: [dfvfs] Changes to replace stat with attributes #52 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 10 months ago by Joachim Metz

Modified:
6 years, 9 months ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[dfvfs] Changes to replace stat with attributes #52 Depends on: https://codereview.appspot.com/320710043/

Patch Set 2 : Changes after review #

Patch Set 3 : Changes to replace stat with attributes #52 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -92 lines)			Patch
M	dfvfs/vfs/sqlite_blob_file_entry.py	View		7 chunks	+35 lines, -42 lines	0 comments	Download
M	dfvfs/vfs/tsk_partition_file_entry.py	View	1 2	5 chunks	+47 lines, -49 lines	0 comments	Download
M	tests/vfs/tsk_partition_file_entry.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

onager

https://codereview.appspot.com/327880043/diff/1/dfvfs/vfs/tsk_partition_file_entry.py File dfvfs/vfs/tsk_partition_file_entry.py (right): https://codereview.appspot.com/327880043/diff/1/dfvfs/vfs/tsk_partition_file_entry.py#newcode80 dfvfs/vfs/tsk_partition_file_entry.py:80: tsk_vs_part (Optional[TODO]): TODO Please complete

6 years, 9 months ago (2017-07-04 14:21:16 UTC) #2

Joachim Metz

6 years, 9 months ago (2017-07-04 16:51:21 UTC) #3

onager

On 2017/07/04 17:06:23, Joachim Metz wrote: > Code updated. LGTM

6 years, 9 months ago (2017-07-05 08:38:16 UTC) #5

Joachim Metz

6 years, 9 months ago (2017-07-13 07:23:45 UTC) #7

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close dfdatetime3

Expand All Messages | Collapse All Messages