Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(6730)

Issue 327840043: [plaso] Add Windows end2end test script, and remove unused ones. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by romaing
Modified:
6 years, 9 months ago
Reviewers:
Joachim Metz
CC:
jberggren, onager, kiddi, log2timeline-dev_googlegroups.com, aaronp
Visibility:
Public.

Description

[plaso] Add Windows end2end test script, and remove unused ones.

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rewrite gplv2 code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+165 lines, -92 lines) Patch
D config/jenkins/jenkins-slave View 1 chunk +0 lines, -54 lines 0 comments Download
D config/jenkins/plaso-jenkins-slave.dockerfile View 1 chunk +0 lines, -38 lines 0 comments Download
A config/jenkins/windows/plaso_end_to_end_windows.ps1 View 1 1 chunk +165 lines, -0 lines 0 comments Download

Messages

Total messages: 6
romaing
6 years, 10 months ago (2017-06-23 13:48:30 UTC) #1
Joachim Metz
https://codereview.appspot.com/327840043/diff/1/config/jenkins/windows/plaso_end_to_end_windows.ps1 File config/jenkins/windows/plaso_end_to_end_windows.ps1 (right): https://codereview.appspot.com/327840043/diff/1/config/jenkins/windows/plaso_end_to_end_windows.ps1#newcode1 config/jenkins/windows/plaso_end_to_end_windows.ps1:1: # Helper script to run automated end-to-end tests on ...
6 years, 10 months ago (2017-06-24 07:11:45 UTC) #2
romaing
Code updated.
6 years, 9 months ago (2017-06-26 13:46:00 UTC) #3
romaing
https://codereview.appspot.com/327840043/diff/1/config/jenkins/windows/plaso_end_to_end_windows.ps1 File config/jenkins/windows/plaso_end_to_end_windows.ps1 (right): https://codereview.appspot.com/327840043/diff/1/config/jenkins/windows/plaso_end_to_end_windows.ps1#newcode1 config/jenkins/windows/plaso_end_to_end_windows.ps1:1: # Helper script to run automated end-to-end tests on ...
6 years, 9 months ago (2017-06-26 13:47:45 UTC) #4
Joachim Metz
LGTM
6 years, 9 months ago (2017-06-27 04:33:25 UTC) #5
romaing
6 years, 9 months ago (2017-06-27 15:12:38 UTC) #6
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close
e2e-scripts-cleanup
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b