[plaso] Make end-to-end tests Windows friendly

[plaso] Make end-to-end tests Windows friendly

* Running tools now calls subprocess.Popen instead of subprocess.call. This makes the use of the stdout an stderr option possible, removing the use of shell redirections
* instantiate subprocess.Popen with a list instead of a string, as superior beings intended. 
* When checking logs, I remove some problematic generated paths that change between platforms
* Sprinkled some u's

[romaing, 2017-06-14 16:27:00]

Sorry for the lame description/title. Renamed in codereview.

On 14 June 2017 at 18:21, <reply@codereview-hr.appspotmail.com> wrote:

> Reviewers: onager,
>
> Description:
> [plaso] happylint
>
> Please review this at http://codereview.appspot.com/327780043/
>
> Affected files (+90, -82 lines):
>   M config/end-to-end.ini
>   M tests/end-to-end.py
>
>
>


-- 
Romain Gayon

[onager, 2017-06-16 07:34:49]

https://codereview.appspot.com/327780043/diff/1/tests/end-to-end.py
File tests/end-to-end.py (right):

https://codereview.appspot.com/327780043/diff/1/tests/end-to-end.py#newcode112
tests/end-to-end.py:112: command (list[str]): command to run.
Please add some more description about what command should be, no spaces,
separate components for different args etc.

https://codereview.appspot.com/327780043/diff/1/tests/end-to-end.py#newcode128
tests/end-to-end.py:128: command, exit_code))
u' '.join(command), not just command

[romaing, 2017-06-19 15:12:08]

Code updated.

[romaing, 2017-06-19 15:38:11]

Code updated.

[romaing, 2017-06-19 15:38:53]

https://codereview.appspot.com/327780043/diff/1/tests/end-to-end.py
File tests/end-to-end.py (right):

https://codereview.appspot.com/327780043/diff/1/tests/end-to-end.py#newcode112
tests/end-to-end.py:112: command (list[str]): command to run.
On 2017/06/16 07:34:49, onager wrote:
> Please add some more description about what command should be, no spaces,
> separate components for different args etc.

Done.

https://codereview.appspot.com/327780043/diff/1/tests/end-to-end.py#newcode128
tests/end-to-end.py:128: command, exit_code))
On 2017/06/16 07:34:49, onager wrote:
> u' '.join(command), not just command

yes and no. Doing so may produce a message that's ambiguous, ie:
[u'test.py', u'argument_one', u'argument_two'] vs [u'test.py', u'argument_one
argument_two']

I guess I could quote-escape all the elements in the command-list before
displaying it and expect the result to be copy-pasteable for debug purposes..
maybe? WDYT?

[onager, 2017-06-19 16:33:05]

https://codereview.appspot.com/327780043/diff/1/tests/end-to-end.py
File tests/end-to-end.py (right):

https://codereview.appspot.com/327780043/diff/1/tests/end-to-end.py#newcode128
tests/end-to-end.py:128: command, exit_code))
On 2017/06/19 15:38:53, romaing wrote:
> On 2017/06/16 07:34:49, onager wrote:
> > u' '.join(command), not just command
> 
> yes and no. Doing so may produce a message that's ambiguous, ie:
> [u'test.py', u'argument_one', u'argument_two'] vs [u'test.py', u'argument_one
> argument_two']
> 
> I guess I could quote-escape all the elements in the command-list before
> displaying it and expect the result to be copy-pasteable for debug purposes..
> maybe? WDYT?

Hmm, no, I think you're right, this is better as is.

https://codereview.appspot.com/327780043/diff/40001/tests/end-to-end.py
File tests/end-to-end.py (right):

https://codereview.appspot.com/327780043/diff/40001/tests/end-to-end.py#newco...
tests/end-to-end.py:112: command (list[str]): full command to run, as expected
by to the Popen()
-to

[romaing, 2017-06-19 16:47:16]

Code updated.

[onager, 2017-06-20 14:58:03]

On 2017/06/19 16:47:16, romaing wrote:
> Code updated.

OK, LGTM, merging.

[romaing, 2017-06-20 15:05:14]

https://codereview.appspot.com/327780043/diff/40001/tests/end-to-end.py
File tests/end-to-end.py (right):

https://codereview.appspot.com/327780043/diff/40001/tests/end-to-end.py#newco...
tests/end-to-end.py:112: command (list[str]): full command to run, as expected
by to the Popen()
On 2017/06/19 16:33:05, onager wrote:
> -to

Done.

[onager, 2017-06-20 15:07:37]

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close command_as_list