Issue 327700043: Retriving DB folder

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 327700043: Retriving DB folder

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 6 months ago by Wei Wang

Modified:
6 years, 6 months ago

Reviewers:
manu_chaud, dkostic, kirill.sc

CC:
brahim Al-Qaysi, farzad2050, yulianlluo, zhubiwen509, Wei Wang

Visibility:
Public.

More Reviews

Description

introduction and script for retriving database BUG=

Patch Set 1 #

Total comments: 4

Created: 6 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+161 lines, -0 lines)			Patch
A	Retrive_data_from_DB/.DS_Store	View	Binary file		0 comments	Download
A	Retrive_data_from_DB/README	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	Retrive_data_from_DB/config.php	View	1 chunk	+5 lines, -0 lines	0 comments	Download
A	Retrive_data_from_DB/index.html	View	1 chunk	+96 lines, -0 lines	4 comments	Download
A	Retrive_data_from_DB/output_xml.php	View	1 chunk	+50 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

manu_chaud

https://codereview.appspot.com/327700043/diff/1/Retrive_data_from_DB/index.html File Retrive_data_from_DB/index.html (right): https://codereview.appspot.com/327700043/diff/1/Retrive_data_from_DB/index.html#newcode35 Retrive_data_from_DB/index.html:35: downloadUrl('http://localhost/wan_phase2_v2/AllgeoHops.xml', function(data) { Could you integrate this file in ...

6 years, 6 months ago (2017-10-15 04:07:27 UTC) #2

Wei Wang

6 years, 6 months ago (2017-10-15 13:52:44 UTC) #3

https://codereview.appspot.com/327700043/diff/1/Retrive_data_from_DB/index.html
File Retrive_data_from_DB/index.html (right):

https://codereview.appspot.com/327700043/diff/1/Retrive_data_from_DB/index.ht...
Retrive_data_from_DB/index.html:35:
downloadUrl('http://localhost/wan_phase2_v2/AllgeoHops.xml', function(data) {
On 2017/10/15 04:07:27, manu_chaud wrote:
> Could you integrate this file in the folder so as to allow easier testing
Thank you for mentioned.
Actually last time, I already git-cl upload the whole folder including
"AllgeoHops.csv" and "AllgeoHops.xml" to this code review website then git push
to our WAN repository.The weird thing is all 6 files were added successfully in
WAN repository but 4 files were added here. 
After saw your comment, I try to add that two files many times. They all failed.
This may be a upload setting by this website(only accept code and shield other
file formats)?  But you still can find the complete folder in our WAN
repository.

https://codereview.appspot.com/327700043/diff/1/Retrive_data_from_DB/index.ht...
Retrive_data_from_DB/index.html:55: text.textContent = address;
On 2017/10/15 04:07:27, manu_chaud wrote:
> Or just:
> var text = document.createTextNode(address);
> so as to avoid one additional statement

Right. Good suggestion.

Expand All Messages | Collapse All Messages