Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8303)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 327240043: Implement visual viewport API

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 7 months ago by ajuma
Modified:
6 years, 4 months ago
Reviewers:
Visibility:
Public.

Description

Implement visual viewport API

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Fix one test in WK1 #

Patch Set 4 : Tests now pass on WK1 desktop #

Patch Set 5 : Starting to work on ios tests #

Patch Set 6 : Progress on ios tests #

Patch Set 7 : ' #

Patch Set 8 : Rebase #

Patch Set 9 : Fix build #

Patch Set 10 : Whitespace fix #

Patch Set 11 : Rebase again #

Patch Set 12 : Convert scaling tests to use UIScriptController #

Patch Set 13 : Remove non-UIScriptController versions #

Patch Set 14 : Fix one more test #

Patch Set 15 : Convert one more test #

Patch Set 16 : Expectations for failing ios tests #

Patch Set 17 : Delete manual tests; WebKit doesn't normally import them #

Patch Set 18 : Clean up tests #

Patch Set 19 : Add runtime flag, clean up a bit #

Patch Set 20 : Address comments and add changelogs #

Patch Set 21 : Remove features.json change #

Patch Set 22 : Address more review comments #

Patch Set 23 : Update Changelogs #

Patch Set 24 : Rebase #

Patch Set 25 : Try to fix Windows. Minor review fixes #

Patch Set 26 : Another Windows build fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+962 lines, -58 lines) Patch
M LayoutTests/ChangeLog View 1 chunk +33 lines, -0 lines 0 comments Download
A LayoutTests/fast/visual-viewport/viewport-dimensions.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +76 lines, -0 lines 0 comments Download
A LayoutTests/fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +78 lines, -0 lines 0 comments Download
A LayoutTests/fast/visual-viewport/viewport-dimensions-exclude-custom-scrollbars-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/visual-viewport/viewport-dimensions-exclude-scrollbars.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +67 lines, -0 lines 0 comments Download
A LayoutTests/fast/visual-viewport/viewport-dimensions-exclude-scrollbars-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/visual-viewport/viewport-dimensions-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/fast/visual-viewport/viewport-dimensions-iframe.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +66 lines, -0 lines 0 comments Download
A LayoutTests/fast/visual-viewport/viewport-dimensions-iframe-expected.txt View 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/fast/visual-viewport/viewport-dimensions-under-page-zoom.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 1 chunk +80 lines, -0 lines 0 comments Download
A LayoutTests/fast/visual-viewport/viewport-dimensions-under-page-zoom-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M LayoutTests/imported/w3c/ChangeLog View 1 chunk +26 lines, -0 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/viewport/viewport-no-resize-event-on-overflow-recalc-expected.txt View 1 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/viewport/viewport-read-size-causes-layout-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/viewport/viewport-read-size-in-iframe-causes-layout-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/viewport/viewport-resize-event-on-load-overflowing-page-expected.txt View 1 2 1 chunk +1 line, -4 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/viewport/viewport-scrollbars-cause-resize-expected.txt View 1 1 chunk +1 line, -2 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/viewport/viewport-type-expected.txt View 1 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/viewport/viewport-unscaled-scale-expected.txt View 1 1 chunk +2 lines, -5 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/viewport/viewport-unscaled-scale-iframe-expected.txt View 1 1 chunk +2 lines, -5 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/viewport/viewport-unscaled-scroll-expected.txt View 1 1 chunk +6 lines, -9 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/viewport/viewport-unscaled-scroll-iframe-expected.txt View 1 1 chunk +6 lines, -9 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/viewport/viewport-unscaled-size-expected.txt View 1 1 chunk +6 lines, -7 lines 0 comments Download
M LayoutTests/imported/w3c/web-platform-tests/viewport/viewport-unscaled-size-iframe-expected.txt View 1 1 chunk +6 lines, -7 lines 0 comments Download
M LayoutTests/platform/gtk/TestExpectations View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 1 chunk +5 lines, -0 lines 0 comments Download
A LayoutTests/platform/ios/fast/visual-viewport/viewport-dimensions-iframe-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +4 lines, -0 lines 0 comments Download
A LayoutTests/platform/ios/imported/w3c/web-platform-tests/viewport/viewport-unscaled-scroll-iframe-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/platform/ios/imported/w3c/web-platform-tests/viewport/viewport-unscaled-size-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/platform/ios/imported/w3c/web-platform-tests/viewport/viewport-unscaled-size-iframe-expected.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +15 lines, -0 lines 0 comments Download
M LayoutTests/platform/mac-wk1/TestExpectations View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebCore/CMakeLists.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +47 lines, -0 lines 0 comments Download
M Source/WebCore/DerivedSources.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/DerivedSources.make View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/Sources.txt View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 2 chunks +2 lines, -0 lines 0 comments Download
M Source/WebCore/WebCore.xcodeproj/project.pbxproj View 6 chunks +14 lines, -0 lines 0 comments Download
M Source/WebCore/bindings/js/WebCoreBuiltinNames.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +2 lines, -0 lines 0 comments Download
M Source/WebCore/dom/EventTargetFactory.in View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/page/DOMWindow.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 3 chunks +4 lines, -0 lines 0 comments Download
M Source/WebCore/page/DOMWindow.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 4 chunks +12 lines, -0 lines 0 comments Download
M Source/WebCore/page/DOMWindow.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +3 lines, -0 lines 0 comments Download
M Source/WebCore/page/Settings.yaml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +3 lines, -0 lines 0 comments Download
A Source/WebCore/page/VisualViewport.h View 1 chunk +61 lines, -0 lines 0 comments Download
A Source/WebCore/page/VisualViewport.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +120 lines, -0 lines 0 comments Download
A Source/WebCore/page/VisualViewport.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 1 chunk +44 lines, -0 lines 0 comments Download
M Source/WebKit/ChangeLog View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/WebKit/Shared/WebPreferences.yaml View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +7 lines, -0 lines 0 comments Download
M Source/WebKitLegacy/mac/ChangeLog View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +18 lines, -0 lines 0 comments Download
M Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKitLegacy/mac/WebView/WebPreferences.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 2 chunks +10 lines, -0 lines 0 comments Download
M Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKitLegacy/mac/WebView/WebView.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebKitLegacy/win/ChangeLog View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +19 lines, -0 lines 0 comments Download
M Source/WebKitLegacy/win/Interfaces/IWebPreferencesPrivate.idl View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebKitLegacy/win/WebPreferenceKeysPrivate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebKitLegacy/win/WebPreferences.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 1 chunk +2 lines, -0 lines 0 comments Download
M Source/WebKitLegacy/win/WebPreferences.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 2 chunks +16 lines, -0 lines 0 comments Download
M Source/WebKitLegacy/win/WebView.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 1 chunk +5 lines, -0 lines 0 comments Download
M Tools/ChangeLog View 1 chunk +14 lines, -0 lines 0 comments Download
M Tools/DumpRenderTree/mac/DumpRenderTree.mm View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 1 chunk +1 line, -0 lines 0 comments Download
M Tools/DumpRenderTree/win/DumpRenderTree.cpp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 2 chunks +2 lines, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b