Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(152)

Issue 327050043: [plaso] Added tests for reading timezone from TZif file #929 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by Joachim Metz
Modified:
2 months, 1 week ago
Reviewers:
aaronp
CC:
jberggren, romaing, onager, kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Added tests for reading timezone from TZif file #929 For reviewer: test_data/BYTECODEGENERATOR.EXE-C1E9BCE6.pf is shown changed because I removed the x file permission bit

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -24 lines) Patch
M plaso/preprocessors/linux.py View 3 chunks +7 lines, -1 line 0 comments Download
A test_data/BYTECODEGENERATOR.EXE-C1E9BCE6.pf View 0 chunks +-1 lines, --1 lines 0 comments Download
A test_data/localtime.tzif View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/preprocessors/linux.py View 3 chunks +33 lines, -2 lines 0 comments Download
M tests/preprocessors/macos.py View 6 chunks +25 lines, -23 lines 0 comments Download

Messages

Total messages: 3
Joachim Metz
2 months, 2 weeks ago (2017-08-08 06:03:45 UTC) #1
aaronp
LGTM
2 months, 1 week ago (2017-08-16 04:59:31 UTC) #2
Joachim Metz
2 months, 1 week ago (2017-08-16 05:05:04 UTC) #3
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close tests929
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted