Issue 326950044: ticket:13289 Fixing engineering notation discrepancy with the LDML spec.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 326950044: ticket:13289 Fixing engineering notation discrepancy with the LDML spec. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 8 months ago by sffc

Modified:
6 years, 8 months ago

Reviewers:
markus.icu

Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/

Visibility:
Public.

More Reviews

Description

ticket:13289 Fixing engineering notation discrepancy with the LDML spec.

Patch Set 1 #

Total comments: 1

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+22 lines, -8 lines)			Patch
M	icu4c/source/test/testdata/numberformattestspecification.txt	View	1 chunk	+5 lines, -4 lines	1 comment	Download
M	icu4j/main/classes/core/src/com/ibm/icu/impl/number/formatters/ScientificFormat.java	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	icu4j/main/tests/core/src/com/ibm/icu/dev/data/numberformattestspecification.txt	View	1 chunk	+5 lines, -4 lines	0 comments	Download
M	icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java	View	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

markus.icu

https://codereview.appspot.com/326950044/diff/1/icu4c/source/test/testdata/numberformattestspecification.txt File icu4c/source/test/testdata/numberformattestspecification.txt (right): https://codereview.appspot.com/326950044/diff/1/icu4c/source/test/testdata/numberformattestspecification.txt#newcode368 icu4c/source/test/testdata/numberformattestspecification.txt:368: // C and J get 29.979246E7 Do they? I ...

6 years, 8 months ago (2017-07-27 20:45:03 UTC) #2

sffc

On 2017/07/27 20:45:03, markus.icu wrote: > https://codereview.appspot.com/326950044/diff/1/icu4c/source/test/testdata/numberformattestspecification.txt > File icu4c/source/test/testdata/numberformattestspecification.txt (right): > > https://codereview.appspot.com/326950044/diff/1/icu4c/source/test/testdata/numberformattestspecification.txt#newcode368 > ...

6 years, 8 months ago (2017-07-27 21:05:02 UTC) #3

sffc

6 years, 8 months ago (2017-08-01 18:13:07 UTC) #5

On 2017/07/28 17:24:52, markus.icu wrote:
> LGTM

Committed revision 40304.

Expand All Messages | Collapse All Messages