Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)

Issue 326740043: [plaso] Refactored options to CLI helpers #160 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months ago by Joachim Metz
Modified:
3 months, 3 weeks ago
Reviewers:
aaronp
CC:
jberggren, romaing, onager, kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Refactored options to CLI helpers #160

Patch Set 1 : Changes for tests #

Total comments: 247

Patch Set 2 : Changes after review and merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2548 lines, -1858 lines) Patch
M plaso/analysis/manager.py View 2 chunks +10 lines, -1 line 0 comments Download
D plaso/cli/analysis_tool.py View 1 chunk +0 lines, -67 lines 0 comments Download
D plaso/cli/extract_analyze_tool.py View 1 chunk +0 lines, -90 lines 0 comments Download
M plaso/cli/extraction_tool.py View 1 11 chunks +9 lines, -114 lines 0 comments Download
M plaso/cli/helpers/__init__.py View 1 chunk +12 lines, -1 line 0 comments Download
A plaso/cli/helpers/analysis_plugins.py View 1 chunk +82 lines, -0 lines 0 comments Download
A plaso/cli/helpers/artifact_definitions.py View 1 chunk +74 lines, -0 lines 0 comments Download
A plaso/cli/helpers/data_location.py View 1 chunk +89 lines, -0 lines 0 comments Download
M plaso/cli/helpers/dynamic_output.py View 3 chunks +9 lines, -6 lines 0 comments Download
A plaso/cli/helpers/event_filters.py View 1 chunk +131 lines, -0 lines 0 comments Download
A plaso/cli/helpers/filter_file.py View 1 chunk +71 lines, -0 lines 0 comments Download
M plaso/cli/helpers/interface.py View 1 chunk +4 lines, -3 lines 0 comments Download
A plaso/cli/helpers/language.py View 1 chunk +58 lines, -0 lines 0 comments Download
M plaso/cli/helpers/manager.py View 1 2 chunks +20 lines, -21 lines 0 comments Download
A plaso/cli/helpers/output_modules.py View 1 chunk +98 lines, -0 lines 0 comments Download
A plaso/cli/helpers/status_view.py View 1 chunk +66 lines, -0 lines 0 comments Download
A plaso/cli/helpers/storage_file.py View 1 chunk +52 lines, -0 lines 0 comments Download
A plaso/cli/helpers/temporary_directory.py View 1 chunk +60 lines, -0 lines 0 comments Download
A plaso/cli/helpers/yara_rules.py View 1 chunk +77 lines, -0 lines 0 comments Download
D plaso/cli/hexdump.py View 1 chunk +0 lines, -76 lines 0 comments Download
M plaso/cli/image_export_tool.py View 8 chunks +17 lines, -6 lines 0 comments Download
M plaso/cli/log2timeline_tool.py View 1 17 chunks +58 lines, -88 lines 0 comments Download
M plaso/cli/pinfo_tool.py View 1 17 chunks +35 lines, -17 lines 0 comments Download
M plaso/cli/psort_tool.py View 1 18 chunks +83 lines, -477 lines 0 comments Download
M plaso/cli/psteal_tool.py View 1 9 chunks +108 lines, -45 lines 0 comments Download
M plaso/cli/storage_media_tool.py View 5 chunks +30 lines, -60 lines 0 comments Download
A plaso/cli/tool_options.py View 1 1 chunk +200 lines, -0 lines 0 comments Download
M plaso/cli/tools.py View 14 chunks +27 lines, -106 lines 0 comments Download
M plaso/engine/engine.py View 1 1 chunk +1 line, -1 line 0 comments Download
M plaso/multi_processing/psort.py View 1 4 chunks +8 lines, -8 lines 0 comments Download
M plaso/output/manager.py View 8 chunks +37 lines, -21 lines 0 comments Download
M plaso/parsers/manager.py View 1 chunk +1 line, -1 line 0 comments Download
M tests/analysis/manager.py View 1 chunk +2 lines, -0 lines 0 comments Download
D tests/cli/analysis_tool.py View 1 chunk +0 lines, -57 lines 0 comments Download
D tests/cli/extract_analyze_tool.py View 1 chunk +0 lines, -97 lines 0 comments Download
M tests/cli/extraction_tool.py View 4 chunks +0 lines, -47 lines 0 comments Download
A tests/cli/helpers/analysis_plugins.py View 1 chunk +72 lines, -0 lines 0 comments Download
A tests/cli/helpers/artifact_definitions.py View 1 chunk +68 lines, -0 lines 0 comments Download
A tests/cli/helpers/data_location.py View 1 chunk +58 lines, -0 lines 0 comments Download
M tests/cli/helpers/dynamic_output.py View 1 chunk +4 lines, -4 lines 0 comments Download
A tests/cli/helpers/event_filters.py View 1 chunk +100 lines, -0 lines 0 comments Download
A tests/cli/helpers/filter_file.py View 1 chunk +67 lines, -0 lines 0 comments Download
A tests/cli/helpers/language.py View 1 chunk +66 lines, -0 lines 0 comments Download
M tests/cli/helpers/manager.py View 1 chunk +0 lines, -7 lines 0 comments Download
A tests/cli/helpers/output_modules.py View 1 chunk +90 lines, -0 lines 0 comments Download
A tests/cli/helpers/status_view.py View 1 chunk +60 lines, -0 lines 0 comments Download
A tests/cli/helpers/storage_file.py View 1 chunk +56 lines, -0 lines 0 comments Download
A tests/cli/helpers/temporary_directory.py View 1 chunk +63 lines, -0 lines 0 comments Download
A tests/cli/helpers/yara_rules.py View 1 chunk +60 lines, -0 lines 0 comments Download
D tests/cli/hexdump.py View 1 chunk +0 lines, -41 lines 0 comments Download
M tests/cli/log2timeline_tool.py View 1 11 chunks +12 lines, -10 lines 0 comments Download
M tests/cli/psort_tool.py View 4 chunks +1 line, -276 lines 0 comments Download
M tests/cli/psteal_tool.py View 1 11 chunks +66 lines, -32 lines 0 comments Download
M tests/cli/status_view.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/cli/storage_media_tool.py View 8 chunks +39 lines, -55 lines 0 comments Download
A tests/cli/tool_options.py View 1 chunk +120 lines, -0 lines 0 comments Download
M tests/cli/tools.py View 4 chunks +11 lines, -21 lines 0 comments Download
M tests/multi_processing/psort.py View 1 3 chunks +3 lines, -2 lines 0 comments Download
M tests/output/manager.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 28
Joachim Metz
6 months ago (2017-05-20 13:16:00 UTC) #1
aaronp
On 2017/05/20 13:16:00, Joachim Metz wrote: FYI: I started to take a look at this ...
6 months ago (2017-05-23 06:34:57 UTC) #2
Joachim Metz
great thx, just FYI this CL is a diffbase on top of https://codereview.appspot.com/317630043/
6 months ago (2017-05-23 06:49:22 UTC) #3
Joachim Metz
great thx, just FYI this CL is a diffbase on top of https://codereview.appspot.com/317630043/
6 months ago (2017-05-23 06:49:23 UTC) #4
Joachim Metz
Code updated.
5 months, 2 weeks ago (2017-06-03 12:54:26 UTC) #5
Joachim Metz
Code updated.
5 months ago (2017-06-21 04:37:05 UTC) #6
Joachim Metz
Code updated.
5 months ago (2017-06-21 06:06:01 UTC) #7
aaronp
On 2017/06/21 06:06:01, Joachim Metz wrote: > Code updated. Ok -- Sorry again for the ...
5 months ago (2017-06-23 01:33:19 UTC) #8
aaronp
https://codereview.appspot.com/326740043/diff/60001/plaso/cli/extraction_tool.py File plaso/cli/extraction_tool.py (left): https://codereview.appspot.com/326740043/diff/60001/plaso/cli/extraction_tool.py#oldcode1 plaso/cli/extraction_tool.py:1: # -*- coding: utf-8 -*- reviewed https://codereview.appspot.com/326740043/diff/60001/plaso/cli/helpers/artifact_definitions.py File plaso/cli/helpers/artifact_definitions.py ...
5 months ago (2017-06-23 01:34:48 UTC) #9
Joachim Metz
https://codereview.appspot.com/326740043/diff/60001/plaso/cli/extraction_tool.py File plaso/cli/extraction_tool.py (left): https://codereview.appspot.com/326740043/diff/60001/plaso/cli/extraction_tool.py#oldcode1 plaso/cli/extraction_tool.py:1: # -*- coding: utf-8 -*- On 2017/06/23 01:34:47, aaronp ...
4 months, 4 weeks ago (2017-06-24 16:40:45 UTC) #10
Joachim Metz
https://codereview.appspot.com/326740043/diff/60001/plaso/cli/helpers/yara_rules.py File plaso/cli/helpers/yara_rules.py (right): https://codereview.appspot.com/326740043/diff/60001/plaso/cli/helpers/yara_rules.py#newcode60 plaso/cli/helpers/yara_rules.py:60: u'Unable to read Yara rules file: {0:s} with error: ...
4 months, 4 weeks ago (2017-06-24 16:42:40 UTC) #11
Joachim Metz
4 months, 4 weeks ago (2017-06-24 16:42:41 UTC) #12
Joachim Metz
Code updated.
4 months, 4 weeks ago (2017-06-24 16:44:49 UTC) #13
aaronp
More partial review done. No need for you to take another look yet. I started ...
4 months, 3 weeks ago (2017-06-29 01:32:22 UTC) #14
Joachim Metz
On 2017/06/29 01:32:22, aaronp wrote: > More partial review done. No need for you to ...
4 months, 3 weeks ago (2017-06-29 15:11:06 UTC) #15
Joachim Metz
Code updated.
4 months, 3 weeks ago (2017-06-30 04:46:13 UTC) #16
Joachim Metz
Code updated.
4 months, 2 weeks ago (2017-07-04 18:22:22 UTC) #17
Joachim Metz
Code updated.
4 months, 2 weeks ago (2017-07-08 15:58:03 UTC) #18
aaronp
Hopefully just one more pass until I'm done. Again, ignore the "Note to self" comments. ...
4 months, 1 week ago (2017-07-14 00:31:43 UTC) #19
aaronp
Getting closer, :). Same notes/caveats apply as the last round. https://codereview.appspot.com/326740043/diff/60001/plaso/cli/helpers/dynamic_output.py File plaso/cli/helpers/dynamic_output.py (right): https://codereview.appspot.com/326740043/diff/60001/plaso/cli/helpers/dynamic_output.py#newcode1 ...
4 months, 1 week ago (2017-07-14 23:59:53 UTC) #20
Joachim Metz
Code updated.
4 months, 1 week ago (2017-07-15 10:26:11 UTC) #21
Joachim Metz
> Getting closer, :). Same notes/caveats apply as the last round. SG, I'll do a ...
4 months ago (2017-07-17 18:57:11 UTC) #22
aaronp
Getting so close. I plan to finish this tomorrow. https://codereview.appspot.com/326740043/diff/60001/plaso/cli/log2timeline_tool.py File plaso/cli/log2timeline_tool.py (left): https://codereview.appspot.com/326740043/diff/60001/plaso/cli/log2timeline_tool.py#oldcode194 plaso/cli/log2timeline_tool.py:194: ...
3 months, 3 weeks ago (2017-07-26 05:00:54 UTC) #23
aaronp
Ok. Really sorry for the long review. Finally finished. I have some comments below on ...
3 months, 3 weeks ago (2017-07-26 22:06:10 UTC) #24
Joachim Metz
thx, I opt ot discuss process improvements outside of this CL.
3 months, 3 weeks ago (2017-07-27 04:02:09 UTC) #25
Joachim Metz
thx, I opt ot discuss process improvements outside of this CL.
3 months, 3 weeks ago (2017-07-27 04:02:09 UTC) #26
Joachim Metz
https://codereview.appspot.com/326740043/diff/60001/plaso/analysis/manager.py File plaso/analysis/manager.py (right): https://codereview.appspot.com/326740043/diff/60001/plaso/analysis/manager.py#newcode1 plaso/analysis/manager.py:1: # -*- coding: utf-8 -*- On 2017/07/14 00:31:41, aaronp ...
3 months, 3 weeks ago (2017-07-27 05:43:56 UTC) #27
Joachim Metz
3 months, 3 weeks ago (2017-07-27 06:07:43 UTC) #28
merged via github due to pylint 1.7 linting conflicts
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4