Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(36)

Issue 326050043: [dfdatetime] Added semantic time convenience classes #54 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 5 days ago by Joachim Metz
Modified:
1 week, 1 day ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfdatetime] Added semantic time convenience classes #54

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M dfdatetime/semantic_time.py View 1 1 chunk +24 lines, -0 lines 0 comments Download
M tests/semantic_time.py View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 6
Joachim Metz
1 week, 5 days ago (2017-07-15 05:41:51 UTC) #1
onager
https://codereview.appspot.com/326050043/diff/1/dfdatetime/semantic_time.py File dfdatetime/semantic_time.py (right): https://codereview.appspot.com/326050043/diff/1/dfdatetime/semantic_time.py#newcode63 dfdatetime/semantic_time.py:63: class InvalidSemanticTime(SemanticTime): These shouldn't have "Semantic" in them. "InvalidTime" ...
1 week, 2 days ago (2017-07-18 14:56:13 UTC) #2
Joachim Metz
Code updated.
1 week, 2 days ago (2017-07-18 19:48:50 UTC) #3
Joachim Metz
https://codereview.appspot.com/326050043/diff/1/dfdatetime/semantic_time.py File dfdatetime/semantic_time.py (right): https://codereview.appspot.com/326050043/diff/1/dfdatetime/semantic_time.py#newcode63 dfdatetime/semantic_time.py:63: class InvalidSemanticTime(SemanticTime): On 2017/07/18 14:56:13, onager wrote: > These ...
1 week, 2 days ago (2017-07-18 19:48:58 UTC) #4
onager
LGTM
1 week, 1 day ago (2017-07-19 10:10:19 UTC) #5
Joachim Metz
1 week, 1 day ago (2017-07-19 15:43:21 UTC) #6
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close fix54
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted