Issue 326050043: [dfdatetime] Added semantic time convenience classes #54

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 326050043: [dfdatetime] Added semantic time convenience classes #54 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 9 months ago by Joachim Metz

Modified:
6 years, 9 months ago

Reviewers:
onager

CC:
kiddi, log2timeline-dev_googlegroups.com

Visibility:
Public.

More Reviews

Description

[dfdatetime] Added semantic time convenience classes #54

Patch Set 2 : Changes after review #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -0 lines)			Patch
	M	dfdatetime/semantic_time.py	View	1	1 chunk	+24 lines, -0 lines	0 comments	Download
	M	tests/semantic_time.py	View	1	1 chunk	+27 lines, -0 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

onager

https://codereview.appspot.com/326050043/diff/1/dfdatetime/semantic_time.py File dfdatetime/semantic_time.py (right): https://codereview.appspot.com/326050043/diff/1/dfdatetime/semantic_time.py#newcode63 dfdatetime/semantic_time.py:63: class InvalidSemanticTime(SemanticTime): These shouldn't have "Semantic" in them. "InvalidTime" ...

6 years, 9 months ago (2017-07-18 14:56:13 UTC) #2

Joachim Metz

6 years, 9 months ago (2017-07-18 19:48:58 UTC) #4

Joachim Metz

6 years, 9 months ago (2017-07-19 15:43:21 UTC) #6

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close fix54

Expand All Messages | Collapse All Messages