Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(518)

Issue 325880043: ticket:13129 Changing default Parse MathContext to 34 digits instead of 16 digits. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by sffc
Modified:
6 years, 9 months ago
Reviewers:
andy.heninger
Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/
Visibility:
Public.

Description

ticket:13129 Changing default Parse MathContext to 34 digits instead of 16 digits.

Patch Set 1 #

Patch Set 2 : Adding another test case. #

Total comments: 2

Patch Set 3 : Replying to Andy #

Messages

Total messages: 7
sffc
6 years, 9 months ago (2017-06-21 02:19:41 UTC) #1
sffc
Adding another test case.
6 years, 9 months ago (2017-06-21 21:33:12 UTC) #2
andy.heninger
https://codereview.appspot.com/325880043/diff/20001/icu4j/main/classes/core/src/com/ibm/icu/impl/number/RoundingUtils.java File icu4j/main/classes/core/src/com/ibm/icu/impl/number/RoundingUtils.java (right): https://codereview.appspot.com/325880043/diff/20001/icu4j/main/classes/core/src/com/ibm/icu/impl/number/RoundingUtils.java#newcode150 icu4j/main/classes/core/src/com/ibm/icu/impl/number/RoundingUtils.java:150: * math context with 16 digits of precision (the ...
6 years, 9 months ago (2017-06-22 18:46:13 UTC) #3
sffc
Replying to Andy
6 years, 9 months ago (2017-06-22 22:30:24 UTC) #4
sffc
https://codereview.appspot.com/325880043/diff/20001/icu4j/main/classes/core/src/com/ibm/icu/impl/number/RoundingUtils.java File icu4j/main/classes/core/src/com/ibm/icu/impl/number/RoundingUtils.java (right): https://codereview.appspot.com/325880043/diff/20001/icu4j/main/classes/core/src/com/ibm/icu/impl/number/RoundingUtils.java#newcode150 icu4j/main/classes/core/src/com/ibm/icu/impl/number/RoundingUtils.java:150: * math context with 16 digits of precision (the ...
6 years, 9 months ago (2017-06-22 22:30:47 UTC) #5
andy.heninger
LGTM
6 years, 9 months ago (2017-06-22 22:51:00 UTC) #6
sffc
6 years, 9 months ago (2017-06-22 23:27:15 UTC) #7
On 2017/06/22 22:51:00, andy.heninger wrote:
> LGTM

Committed revision 40194.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b