Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2272)

Issue 325800043: Fixes to midi2ly.py: better note lengths, now supports meter changes

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by pkx166h
Modified:
6 years, 10 months ago
Reviewers:
CC:
lilypond-devel_gnu.org, christopher.heckman_asu.edu
Visibility:
Public.

Description

Fixes to midi2ly.py: better note lengths, now supports meter changes (1) Note lengths currently are fractions like 61/120. If the numerator can be changed by 1 to get a better fraction, it is done. Quarter notes are also replaced with eighths/sixteenths if appropriate. For example: a duration of 4*61/120 is changed to 4*1/2 and then to 8. (2) Current version of midi2ly does not support meter changes. Patch does. Resolves: #5119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -50 lines) Patch
M scripts/midi2ly.py View 16 chunks +87 lines, -50 lines 0 comments Download

Messages

Total messages: 2
pkx166h
This fails a basic 'make' when applied to current master. Also Christopher, if and when ...
6 years, 10 months ago (2017-05-27 09:00:04 UTC) #1
Christopher.Heckman_asu.edu
6 years, 10 months ago (2017-05-28 04:10:32 UTC) #2
On Sat, May 27, 2017 at 4:00 AM,  <pkx166h@gmail.com> wrote:
> Reviewers: ,
>
> Message:
> This fails a basic 'make' when applied to current master.

It works for me.

> Also Christopher, if and when you submit a new patch, can you clean up
> the whitespace errors that are also reported ('git apply' squelches
> some, but I can see that you are using tabs in the diff on Rietveld and
> this will cause comments by other devs). Also see:
>
>
http://lilypond.org/doc/v2.19/Documentation/contributor-big-page#policy-decis...

Okay, I'll take a look.

--- Chris

> regards
>
> Description:
> Fixes to midi2ly.py: better note lengths, now supports meter changes
>
> (1) Note lengths currently are fractions like 61/120. If the numerator
> can be changed by 1 to get a better fraction, it is done. Quarter
> notes are also replaced with eighths/sixteenths if appropriate.
> For example: a duration of 4*61/120 is changed to 4*1/2 and then
> to 8. (2) Current version of midi2ly does not support meter changes.
> Patch does.
>
> Resolves: #5119
>
> Please review this at https://codereview.appspot.com/325800043/
>
> Affected files (+87, -50 lines):
>   M scripts/midi2ly.py
>
>



-- 
==================================
Christopher Carl Heckman
Honors Faculty
Lecturer
33° 25' 7'' N, 111° 55' 55'' W
ECA 212
School of Mathematical & Statistical Sciences
Arizona State University (T1N R4E Sect22 NW1/4)
Tempe, AZ 85287 - 1804
United States of America
North America
Planet Earth
Solar System
Gould Belt
Local Bubble
Local Fluff
Milky Way Galaxy, Orion Arm
Local Group
Virgo Supercluster
Pisces-Cetus Supercluster Complex
Universe
Multiverse
==================================
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b