Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2844)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 325270043: [plaso] Changes for Unicode issue #1468 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by Joachim Metz
Modified:
6 years, 6 months ago
Reviewers:
onager
CC:
jberggren, kiddi, log2timeline-dev_googlegroups.com, aaronp, romaing
Visibility:
Public.

Description

[plaso] Changes for Unicode issue #1468 Depends on: * https://codereview.appspot.com/332950043/

Patch Set 1 #

Total comments: 4

Patch Set 2 : Changes for Unicode issue #1468 #

Patch Set 3 : Changes for Unicode issue #1468 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+184 lines, -192 lines) Patch
M config/dpkg/control View 1 1 chunk +1 line, -1 line 0 comments Download
M dependencies.ini View 1 1 chunk +1 line, -1 line 0 comments Download
M plaso/parsers/dpkg.py View 1 3 chunks +4 lines, -3 lines 0 comments Download
M plaso/parsers/iis.py View 1 1 chunk +1 line, -1 line 0 comments Download
M plaso/parsers/mac_appfirewall.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M plaso/parsers/mac_securityd.py View 1 1 chunk +1 line, -1 line 0 comments Download
M plaso/parsers/mac_wifi.py View 1 1 chunk +1 line, -1 line 0 comments Download
M plaso/parsers/opera.py View 1 6 chunks +45 lines, -35 lines 0 comments Download
M plaso/parsers/popcontest.py View 8 chunks +49 lines, -40 lines 0 comments Download
M plaso/parsers/selinux.py View 1 2 chunks +3 lines, -1 line 0 comments Download
M plaso/parsers/skydrivelog.py View 1 2 chunks +2 lines, -2 lines 0 comments Download
M plaso/parsers/text_parser.py View 1 8 chunks +36 lines, -47 lines 0 comments Download
M plaso/parsers/winfirewall.py View 1 2 chunks +4 lines, -2 lines 0 comments Download
M plaso/parsers/xchatlog.py View 1 4 chunks +5 lines, -6 lines 0 comments Download
M plaso/parsers/xchatscrollback.py View 1 3 chunks +3 lines, -4 lines 0 comments Download
M plaso/parsers/zsh_extended_history.py View 1 1 chunk +2 lines, -0 lines 0 comments Download
M requirements.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M setup.cfg View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/popcontest.py View 1 2 12 chunks +12 lines, -24 lines 0 comments Download
M tests/parsers/winfirewall.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/parsers/xchatscrollback.py View 1 2 8 chunks +9 lines, -18 lines 0 comments Download

Messages

Total messages: 9
Joachim Metz
6 years, 8 months ago (2017-08-18 08:05:38 UTC) #1
Joachim Metz
https://codereview.appspot.com/325270043/diff/1/plaso/parsers/text_parser.py File plaso/parsers/text_parser.py (right): https://codereview.appspot.com/325270043/diff/1/plaso/parsers/text_parser.py#newcode495 plaso/parsers/text_parser.py:495: # Ignore a byte-order mark at this point the ...
6 years, 8 months ago (2017-08-18 08:32:38 UTC) #2
onager
https://codereview.appspot.com/325270043/diff/1/plaso/parsers/xchatlog.py File plaso/parsers/xchatlog.py (right): https://codereview.appspot.com/325270043/diff/1/plaso/parsers/xchatlog.py#newcode108 plaso/parsers/xchatlog.py:108: pyparsing.Keyword('Th') | Looks like the find and replace got ...
6 years, 7 months ago (2017-09-08 12:08:59 UTC) #3
Joachim Metz
https://codereview.appspot.com/325270043/diff/1/plaso/parsers/text_parser.py File plaso/parsers/text_parser.py (right): https://codereview.appspot.com/325270043/diff/1/plaso/parsers/text_parser.py#newcode495 plaso/parsers/text_parser.py:495: # Ignore a byte-order mark at this point the ...
6 years, 6 months ago (2017-10-19 06:38:21 UTC) #4
Joachim Metz
https://codereview.appspot.com/325270043/diff/1/plaso/parsers/text_parser.py File plaso/parsers/text_parser.py (right): https://codereview.appspot.com/325270043/diff/1/plaso/parsers/text_parser.py#newcode495 plaso/parsers/text_parser.py:495: # Ignore a byte-order mark at this point the ...
6 years, 6 months ago (2017-10-19 06:38:21 UTC) #5
Joachim Metz
Code updated.
6 years, 6 months ago (2017-10-19 09:13:30 UTC) #6
onager
LGTM
6 years, 6 months ago (2017-10-23 17:58:56 UTC) #7
Joachim Metz
Code updated.
6 years, 6 months ago (2017-10-23 18:50:38 UTC) #8
Joachim Metz
6 years, 6 months ago (2017-10-23 19:31:08 UTC) #9 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close textparse
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b