Issue 325250043: [plaso] Changes to handle preferred time zone when not set #929

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 325250043: [plaso] Changes to handle preferred time zone when not set #929 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 8 months ago by Joachim Metz

Modified:
6 years, 8 months ago

Reviewers:
jberggren

CC:
romaing, onager, kiddi, log2timeline-dev_googlegroups.com, aaronp

Visibility:
Public.

More Reviews

Description

[plaso] Changes to handle preferred time zone when not set #929

Patch Set 1 #

Patch Set 2 : Added tests for preferred time zone option parsing #929 #

Patch Set 3 : Changes for end-to-end tests #

Patch Set 4 : Changes for end-to-end tests #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+682 lines, -587 lines)			Patch
M	plaso/cli/helpers/event_filters.py	View	1 2	4 chunks	+42 lines, -40 lines	0 comments	Download
M	plaso/cli/log2timeline_tool.py	View	1 2 3	20 chunks	+136 lines, -133 lines	0 comments	Download
M	plaso/cli/psort_tool.py	View	1 2	19 chunks	+94 lines, -91 lines	0 comments	Download
M	plaso/cli/psteal_tool.py	View		23 chunks	+88 lines, -85 lines	0 comments	Download
M	plaso/cli/tools.py	View	1	30 chunks	+114 lines, -110 lines	0 comments	Download
M	plaso/engine/knowledge_base.py	View		14 chunks	+30 lines, -24 lines	0 comments	Download
M	tests/cli/tools.py	View	1	14 chunks	+178 lines, -104 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

jberggren

On 2017/08/16 06:34:00, Joachim Metz wrote: > Code updated. LGTM

6 years, 8 months ago (2017-08-16 14:30:02 UTC) #5

Joachim Metz

6 years, 8 months ago (2017-08-16 19:06:44 UTC) #6

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close defaulttz

Expand All Messages | Collapse All Messages