Issue 324960043: ICU ticket #13240: fixes a code coverage test for hashCode method in DateFormat class.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 10 months ago by nrunge

Modified:
6 years, 10 months ago

Reviewers:
andy.heninger, markus.icu

CC:
yoshito_umaoka_us.ibm.com

Base URL:
svn+ssh://source.icu-project.org/repos/icu/trunk/icu4j/

Visibility:
Public.

ICU ticket #13240: fixes a code coverage test for hashCode method in DateFormat class.

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -9 lines)			Patch
	M	main/tests/core/src/com/ibm/icu/dev/test/format/TestMessageFormat.java	View		2 chunks	+5 lines, -9 lines	0 comments	Download

Total messages: 4

nrunge

On 2017/06/21 16:45:48, nrunge wrote: The purpose of this test is to provide code coverage ...

6 years, 10 months ago (2017-06-21 16:49:28 UTC) #2

markus.icu

LGTM You might add a comment that this is mostly a code coverage test.

6 years, 10 months ago (2017-06-22 07:33:59 UTC) #3

nrunge

6 years, 10 months ago (2017-06-22 18:22:45 UTC) #4

On 2017/06/22 07:33:59, markus.icu wrote:
> LGTM
> 
> You might add a comment that this is mostly a code coverage test.

Done.