Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1850)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 324950043: ticket:13231 Changing DecimalFormat min/max setters to use the most recent setting instead of alway… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by sffc
Modified:
6 years, 10 months ago
Reviewers:
andy.heninger
Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/
Visibility:
Public.

Description

ticket:13231 Changing DecimalFormat min/max setters to use the most recent setting instead of always preferring the minimum

Patch Set 1 #

Total comments: 2

Patch Set 2 : First round of feedback. #

Patch Set 3 : Fixing test failure in serialization. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -1 line) Patch
M icu4j/main/classes/core/src/com/ibm/icu/text/DecimalFormat.java View 1 2 12 chunks +49 lines, -0 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java View 1 2 3 chunks +45 lines, -1 line 0 comments Download

Messages

Total messages: 7
sffc
6 years, 10 months ago (2017-06-19 21:42:10 UTC) #1
andy.heninger
https://codereview.appspot.com/324950043/diff/1/icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java File icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java (right): https://codereview.appspot.com/324950043/diff/1/icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java#newcode4707 icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java:4707: System.out.println(df.getMinimumIntegerDigits()); Shouldn't have stray output in the test.
6 years, 10 months ago (2017-06-19 23:10:46 UTC) #2
sffc
First round of feedback.
6 years, 10 months ago (2017-06-20 03:57:12 UTC) #3
sffc
https://codereview.appspot.com/324950043/diff/1/icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java File icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java (right): https://codereview.appspot.com/324950043/diff/1/icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java#newcode4707 icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java:4707: System.out.println(df.getMinimumIntegerDigits()); On 2017/06/19 23:10:46, andy.heninger wrote: > Shouldn't have ...
6 years, 10 months ago (2017-06-20 03:57:47 UTC) #4
sffc
Fixing test failure in serialization.
6 years, 10 months ago (2017-06-20 04:34:50 UTC) #5
andy.heninger
LGTM
6 years, 10 months ago (2017-06-21 00:42:27 UTC) #6
sffc
6 years, 10 months ago (2017-06-21 00:44:59 UTC) #7 
On 2017/06/21 00:42:27, andy.heninger wrote:
> LGTM

Committed revision 40186.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b