Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(347)

Issue 324770043: tools: spawn the process of ibus-ui-emojier (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by Peng Wu
Modified:
6 years, 11 months ago
Reviewers:
shawn.p.huang, fujiwara, Peng
Visibility:
Public.

Description

tools: spawn the process of ibus-ui-emojier BUG=

Patch Set 1 #

Total comments: 1

Patch Set 2 : tools: spawn the process of ibus-ui-emojier #

Total comments: 2

Patch Set 3 : tools: spawn the process of ibus-ui-emojier #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -59 lines) Patch
M bindings/vala/config.vapi View 1 chunk +1 line, -0 lines 0 comments Download
M tools/Makefile.am View 1 chunk +1 line, -0 lines 0 comments Download
M tools/main.vala View 1 2 1 chunk +13 lines, -59 lines 0 comments Download

Messages

Total messages: 9
Peng Wu
Please review it, thanks!
6 years, 11 months ago (2017-04-10 08:18:06 UTC) #1
fujiwara
https://codereview.appspot.com/324770043/diff/1/tools/main.vala File tools/main.vala (right): https://codereview.appspot.com/324770043/diff/1/tools/main.vala#newcode353 tools/main.vala:353: cmd += " --font " + emoji_font; How about ...
6 years, 11 months ago (2017-04-10 08:28:59 UTC) #2
Peng Wu
Please review it again, thanks!
6 years, 11 months ago (2017-04-11 05:38:14 UTC) #3
fujiwara
https://codereview.appspot.com/324770043/diff/40001/tools/main.vala File tools/main.vala (right): https://codereview.appspot.com/324770043/diff/40001/tools/main.vala#newcode334 tools/main.vala:334: argv[0] = cmd; I think this does not work ...
6 years, 11 months ago (2017-04-11 09:50:47 UTC) #4
Peng Wu
Please review it again, thanks!
6 years, 11 months ago (2017-04-12 09:48:00 UTC) #5
fujiwara
lgtm Thank you for working on this. If you have time, please also investigate the ...
6 years, 11 months ago (2017-04-12 11:15:51 UTC) #6
Peng
On 2017/04/12 11:15:51, fujiwara wrote: > lgtm > Thank you for working on this. > ...
6 years, 11 months ago (2017-04-12 11:45:32 UTC) #7
fujiwara
Committed. Could you close the issue? OK, I should use `git cl patch` instead of ...
6 years, 11 months ago (2017-04-13 03:47:13 UTC) #8
Peng Wu
6 years, 11 months ago (2017-04-13 05:58:38 UTC) #9
Message was sent while issue was closed.
closed.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b