[plaso] Changed profiling UX #1043

[plaso] Changed profiling UX #1043

[Joachim Metz, 2017-04-09 16:54:28]

https://codereview.appspot.com/324760043/diff/1/plaso/cli/tools.py
File plaso/cli/tools.py (right):

https://codereview.appspot.com/324760043/diff/1/plaso/cli/tools.py#newcode356
plaso/cli/tools.py:356: default=u'none', metavar=u'PROFILERS_LIST', help=(
note to self change default=u'none'

[onager, 2017-04-09 18:44:02]

Some initial notes. It's strange to refer to "profilers" when they don't exist
as objects anywhere in Plaso.

https://codereview.appspot.com/324760043/diff/1/plaso/cli/tools.py
File plaso/cli/tools.py (right):

https://codereview.appspot.com/324760043/diff/1/plaso/cli/tools.py#newcode357
plaso/cli/tools.py:357: u'Define a list of profiles to use by the tool. This is
a comma '
profilers

https://codereview.appspot.com/324760043/diff/1/plaso/engine/configurations.py
File plaso/engine/configurations.py (right):

https://codereview.appspot.com/324760043/diff/1/plaso/engine/configurations.p...
plaso/engine/configurations.py:96: profilers (str): profilers.
This isn't a string any more, it's a set of strings

https://codereview.appspot.com/324760043/diff/1/plaso/engine/configurations.p...
plaso/engine/configurations.py:99: * 'guppy' to profile memory usage using
guppy;
Please rewrite these to something like "guppy, which profiles memory usage".

[Joachim Metz, 2017-04-10 04:04:02]

On 2017/04/09 18:44:02, onager wrote:
> Some initial notes. It's strange to refer to "profilers" when they don't exist
> as objects anywhere in Plaso.

Not sure what you mean "they don't exist as objects anywhere in Plaso"?

See: plaso/engine/profiler.py

[Joachim Metz, 2017-04-10 04:04:10]

https://codereview.appspot.com/324760043/diff/1/plaso/cli/tools.py
File plaso/cli/tools.py (right):

https://codereview.appspot.com/324760043/diff/1/plaso/cli/tools.py#newcode356
plaso/cli/tools.py:356: default=u'none', metavar=u'PROFILERS_LIST', help=(
On 2017/04/09 16:54:28, Joachim Metz wrote:
> note to self change default=u'none'

Done.

https://codereview.appspot.com/324760043/diff/1/plaso/cli/tools.py#newcode357
plaso/cli/tools.py:357: u'Define a list of profiles to use by the tool. This is
a comma '
On 2017/04/09 18:44:01, onager wrote:
> profilers

Done.

https://codereview.appspot.com/324760043/diff/1/plaso/engine/configurations.py
File plaso/engine/configurations.py (right):

https://codereview.appspot.com/324760043/diff/1/plaso/engine/configurations.p...
plaso/engine/configurations.py:96: profilers (str): profilers.
On 2017/04/09 18:44:01, onager wrote:
> This isn't a string any more, it's a set of strings

Done.

https://codereview.appspot.com/324760043/diff/1/plaso/engine/configurations.p...
plaso/engine/configurations.py:99: * 'guppy' to profile memory usage using
guppy;
On 2017/04/09 18:44:01, onager wrote:
> Please rewrite these to something like "guppy, which profiles memory usage".

Done.

[Joachim Metz, 2017-04-10 04:07:22]

Code updated.

[onager, 2017-05-11 08:58:25]

On 2017/04/10 04:07:22, Joachim Metz wrote:
> Code updated.

LGTM

[Joachim Metz, 2017-05-11 20:26:57]

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close profile