Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(44)

Issue 324760043: [plaso] Changed profiling UX #1043

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 6 days ago by Joachim Metz
Modified:
2 weeks, 5 days ago
Reviewers:
jberggren, romaing, onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Changed profiling UX #1043

Patch Set 1 #

Total comments: 8

Patch Set 2 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+227 lines, -185 lines) Patch
M plaso/cli/extraction_tool.py View 7 chunks +0 lines, -77 lines 0 comments Download
M plaso/cli/tools.py View 1 7 chunks +99 lines, -2 lines 0 comments Download
M plaso/engine/configurations.py View 1 5 chunks +22 lines, -15 lines 0 comments Download
M plaso/engine/engine.py View 1 1 chunk +3 lines, -3 lines 0 comments Download
M plaso/engine/single_process.py View 4 chunks +9 lines, -9 lines 0 comments Download
M plaso/frontend/extraction_frontend.py View 2 chunks +0 lines, -5 lines 0 comments Download
M plaso/frontend/psort.py View 1 chunk +0 lines, -1 line 0 comments Download
M plaso/multi_processing/task_engine.py View 5 chunks +11 lines, -11 lines 0 comments Download
M plaso/multi_processing/worker_process.py View 4 chunks +9 lines, -9 lines 0 comments Download
M tests/cli/extraction_tool.py View 2 chunks +0 lines, -41 lines 0 comments Download
M tests/cli/tools.py View 1 3 chunks +61 lines, -3 lines 0 comments Download
M tests/engine/engine.py View 1 chunk +3 lines, -3 lines 0 comments Download
M tools/log2timeline.py View 5 chunks +9 lines, -5 lines 0 comments Download
M tools/psort.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6
Joachim Metz
2 weeks, 6 days ago (2017-04-09 16:36:09 UTC) #1
Joachim Metz
https://codereview.appspot.com/324760043/diff/1/plaso/cli/tools.py File plaso/cli/tools.py (right): https://codereview.appspot.com/324760043/diff/1/plaso/cli/tools.py#newcode356 plaso/cli/tools.py:356: default=u'none', metavar=u'PROFILERS_LIST', help=( note to self change default=u'none'
2 weeks, 6 days ago (2017-04-09 16:54:28 UTC) #2
onager
Some initial notes. It's strange to refer to "profilers" when they don't exist as objects ...
2 weeks, 6 days ago (2017-04-09 18:44:02 UTC) #3
Joachim Metz
On 2017/04/09 18:44:02, onager wrote: > Some initial notes. It's strange to refer to "profilers" ...
2 weeks, 5 days ago (2017-04-10 04:04:02 UTC) #4
Joachim Metz
https://codereview.appspot.com/324760043/diff/1/plaso/cli/tools.py File plaso/cli/tools.py (right): https://codereview.appspot.com/324760043/diff/1/plaso/cli/tools.py#newcode356 plaso/cli/tools.py:356: default=u'none', metavar=u'PROFILERS_LIST', help=( On 2017/04/09 16:54:28, Joachim Metz wrote: ...
2 weeks, 5 days ago (2017-04-10 04:04:10 UTC) #5
Joachim Metz
2 weeks, 5 days ago (2017-04-10 04:07:22 UTC) #6
Code updated.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted