Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(210)

Issue 324560043: Get Request

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 weeks, 3 days ago by Vasileios Papageorgiou
Modified:
1 week, 2 days ago
Reviewers:
paul.busi38, michail.xirouchakis, dkostic, alireza.farshin
CC:
younes.tahri3, 2016shana2333, engr.sikandar.iqbal
Visibility:
Public.

Description

minor change BUG=Rest Api on the nfm

Patch Set 1 #

Patch Set 2 : Nfm posts json data to DM #

Total comments: 2

Patch Set 3 : minor change #

Total comments: 1

Patch Set 4 : Get_Request #

Patch Set 5 : Fix Get with arguments #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M cpm/Get.py View 1 2 3 4 3 chunks +6 lines, -4 lines 1 comment Download

Messages

Total messages: 4
Michail.Xirouchakis
Check feedback regarding the delta calculation between two consecutive NFM measurements. It needs to be ...
2 weeks, 4 days ago (2017-10-03 13:30:39 UTC) #1
2016shana2333
Code review https://codereview.appspot.com/324560043/diff/20001/nfm/SimpleNFM13.py File nfm/SimpleNFM13.py (right): https://codereview.appspot.com/324560043/diff/20001/nfm/SimpleNFM13.py#newcode2 nfm/SimpleNFM13.py:2: delete useless space between different import https://codereview.appspot.com/324560043/diff/20001/nfm/SimpleNFM13.py#newcode140 ...
2 weeks, 4 days ago (2017-10-03 15:18:12 UTC) #2
Vasileios Papageorgiou
1 week, 2 days ago (2017-10-12 12:11:02 UTC) #3
Michail.Xirouchakis
1 week, 2 days ago (2017-10-12 12:18:08 UTC) #4
Hello Vasileios,

I just added a suggestion for line 58.

https://codereview.appspot.com/324560043/diff/80001/cpm/Get.py
File cpm/Get.py (right):

https://codereview.appspot.com/324560043/diff/80001/cpm/Get.py#newcode58
cpm/Get.py:58: a = GetRequest(sys.argv[1], int(sys.argv[2]))
Since this file will be a module (imported to CPM), please add:

if __name__ == "__main__":
     GetRequest(sys.argv[1], int(sys.argv[2]))

so that this last part of the code only executes if your file is executed as a
script. More info: 

https://docs.python.org/2/tutorial/modules.html#executing-modules-as-scripts
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted