Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(342)

Issue 324560043: Admission Control

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by Vasileios Papageorgiou
Modified:
5 minutes ago
CC:
2016shana2333, engr.sikandar.iqbal, sdnik2200ht17_ict.kth.se;
Visibility:
Public.

Description

minor change BUG=Rest Api on the nfm

Patch Set 1 #

Patch Set 2 : Nfm posts json data to DM #

Total comments: 2

Patch Set 3 : minor change #

Total comments: 1

Patch Set 4 : Get_Request #

Patch Set 5 : Fix Get with arguments #

Total comments: 2

Patch Set 6 : Admission Control logic #

Patch Set 7 : Admission Control #

Patch Set 8 : Deny function of admission Control #

Patch Set 9 : Update on Admission logic #

Total comments: 1

Patch Set 10 : Hard time out for adding flow #

Unified diffs Side-by-side diffs Delta from patch set Stats (+329 lines, -179 lines) Patch
M cpm/cpm_13.py View 1 2 3 4 5 6 7 8 9 10 chunks +329 lines, -179 lines 0 comments Download

Messages

Total messages: 14
Michail.Xirouchakis
Check feedback regarding the delta calculation between two consecutive NFM measurements. It needs to be ...
2 months, 1 week ago (2017-10-03 13:30:39 UTC) #1
2016shana2333
Code review https://codereview.appspot.com/324560043/diff/20001/nfm/SimpleNFM13.py File nfm/SimpleNFM13.py (right): https://codereview.appspot.com/324560043/diff/20001/nfm/SimpleNFM13.py#newcode2 nfm/SimpleNFM13.py:2: delete useless space between different import https://codereview.appspot.com/324560043/diff/20001/nfm/SimpleNFM13.py#newcode140 ...
2 months, 1 week ago (2017-10-03 15:18:12 UTC) #2
Vasileios Papageorgiou
2 months ago (2017-10-12 12:11:02 UTC) #3
Michail.Xirouchakis
Hello Vasileios, I just added a suggestion for line 58. https://codereview.appspot.com/324560043/diff/80001/cpm/Get.py File cpm/Get.py (right): https://codereview.appspot.com/324560043/diff/80001/cpm/Get.py#newcode58 ...
2 months ago (2017-10-12 12:18:08 UTC) #4
Vasileios Papageorgiou
Hi, I tried to make admission control logic on CPM_13 I put it on wrong ...
1 week, 5 days ago (2017-11-29 16:24:32 UTC) #5
Vasileios Papageorgiou
Hi, Younes me and Sikandar we defined some logic for admission control. Check the new ...
1 week, 4 days ago (2017-11-30 15:56:04 UTC) #6
Michail.Xirouchakis
On 2017/11/30 15:56:04, Vasileios Papageorgiou wrote: > Hi, > > Younes me and Sikandar we ...
1 week, 1 day ago (2017-12-03 16:53:57 UTC) #7
Vasileios Papageorgiou
On 2017/12/03 16:53:57, Michail.Xirouchakis wrote: > On 2017/11/30 15:56:04, Vasileios Papageorgiou wrote: > > Hi, ...
1 week, 1 day ago (2017-12-03 17:02:33 UTC) #8
Michail.Xirouchakis
On 2017/12/03 17:02:33, Vasileios Papageorgiou wrote: > On 2017/12/03 16:53:57, Michail.Xirouchakis wrote: > > On ...
1 week, 1 day ago (2017-12-03 17:08:01 UTC) #9
Vasileios Papageorgiou
Hi, I added the decision making function that is required after calling the admission conrol ...
1 week, 1 day ago (2017-12-03 21:25:54 UTC) #10
Michail.Xirouchakis
Hello Vasileios, I have not run your code. But it makes little sense to me ...
1 week ago (2017-12-05 13:04:20 UTC) #11
Vasileios Papageorgiou
Hi, Check the update of Admission Control. https://codereview.appspot.com/324560043/diff/160001/RPM/cpm_13.py BR, Vasilis
1 week ago (2017-12-05 15:04:55 UTC) #12
younes.tahri3
https://codereview.appspot.com/324560043/diff/160001/RPM/cpm_13.py File RPM/cpm_13.py (right): https://codereview.appspot.com/324560043/diff/160001/RPM/cpm_13.py#newcode150 RPM/cpm_13.py:150: if packet_headers['tcp_dst'] or packet_headers['tcp_src'] == 10001: Why are they ...
1 week ago (2017-12-05 15:11:38 UTC) #13
Michail.Xirouchakis
6 days, 22 hours ago (2017-12-05 16:48:37 UTC) #14
Hello all,

Code is currently correct and works as intended.
Vasileios and I tested it in the classroom.

Demo video:
https://youtu.be/TNlpvK32svg

Latest CPM with Admission Control:
https://gits-15.sys.kth.se/vpap/Communication-System-Design_SDN/blob/cpm_dev_...

BR,
Michail
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d