Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(386)

Issue 323960043: [dfwinreg] Replaced fnmatch.translate with custom function #60 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by Joachim Metz
Modified:
6 years, 8 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfwinreg] Replaced fnmatch.translate with custom function #60

Patch Set 1 #

Patch Set 2 : Changes after review #

Total comments: 4

Patch Set 3 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+158 lines, -13 lines) Patch
A dfwinreg/glob2regex.py View 1 1 chunk +85 lines, -0 lines 0 comments Download
M dfwinreg/registry_searcher.py View 1 2 chunks +10 lines, -13 lines 0 comments Download
A tests/glob2regex.py View 1 2 1 chunk +63 lines, -0 lines 0 comments Download

Messages

Total messages: 11
Joachim Metz
6 years, 9 months ago (2017-06-27 06:33:22 UTC) #1
onager
LGTM
6 years, 9 months ago (2017-07-04 07:26:02 UTC) #2
onager
On 2017/07/04 07:26:02, onager wrote: > LGTM Note that this will need some minor changes ...
6 years, 9 months ago (2017-07-04 07:26:56 UTC) #3
Joachim Metz
Ack I needed to change the algorithm a bit as well to handle edge cases
6 years, 8 months ago (2017-07-05 03:52:50 UTC) #4
Joachim Metz
Code updated.
6 years, 8 months ago (2017-07-05 03:54:07 UTC) #5
Joachim Metz
PTAL
6 years, 8 months ago (2017-07-05 03:54:44 UTC) #6
Joachim Metz
Code updated.
6 years, 8 months ago (2017-07-05 04:09:02 UTC) #7
onager
https://codereview.appspot.com/323960043/diff/40001/tests/glob2regex.py File tests/glob2regex.py (right): https://codereview.appspot.com/323960043/diff/40001/tests/glob2regex.py#newcode49 tests/glob2regex.py:49: def testGlob2Regex(self): These all test compatibility between the _Glob2Regex ...
6 years, 8 months ago (2017-07-05 08:22:10 UTC) #8
Joachim Metz
Code updated.
6 years, 8 months ago (2017-07-06 04:40:47 UTC) #9
Joachim Metz
https://codereview.appspot.com/323960043/diff/40001/tests/glob2regex.py File tests/glob2regex.py (right): https://codereview.appspot.com/323960043/diff/40001/tests/glob2regex.py#newcode49 tests/glob2regex.py:49: def testGlob2Regex(self): On 2017/07/05 08:22:09, onager wrote: > These ...
6 years, 8 months ago (2017-07-06 04:41:00 UTC) #10
Joachim Metz
6 years, 8 months ago (2017-07-06 04:42:30 UTC) #11
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close glob
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b