Issue 323820043: [dfvfs] Fix bug with negative seeks for encrypted, encoded, and compressed streams. #183

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 323820043: [dfvfs] Fix bug with negative seeks for encrypted, encoded, and compressed streams. #183 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 11 months ago by dc3.plaso

Modified:
6 years, 9 months ago

Reviewers:
Joachim Metz, bluenlonesome83

CC:
kiddi, log2timeline-dev_googlegroups.com, onager

Visibility:
Public.

[dfvfs] Fix bug with negative seeks for encrypted, encoded, and compressed streams. #183

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -6 lines)			Patch
M	dfvfs/file_io/compressed_stream_io.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	dfvfs/file_io/encoded_stream_io.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	dfvfs/file_io/encrypted_stream_io.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/file_io/test_lib.py	View	2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 6

Joachim Metz

Let me double check if the proposed solution does not introduce offset drift.

6 years, 11 months ago (2017-05-10 05:33:27 UTC) #2

dc3.plaso

On 2017/05/10 05:33:27, Joachim Metz wrote: > Let me double check if the proposed solution ...

6 years, 10 months ago (2017-06-23 13:36:15 UTC) #4

Joachim Metz

Sorry for the delay, I took a closer look and LGTM Thanks for fixing this ...

6 years, 10 months ago (2017-06-25 10:05:34 UTC) #5

Joachim Metz

6 years, 10 months ago (2017-06-25 11:03:06 UTC) #6

merged:
https://github.com/log2timeline/dfvfs/commit/a889480caea51b5580ce140c26286835...