Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(197)

Issue 323780043: ui/gtk3: Fix build failures (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by fujiwara
Modified:
6 years, 11 months ago
Reviewers:
shawn.p.huang, Peng
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

ui/gtk3: Fix build failures Add-on fix to 290f786 if /usr/share/vala*/vapi/ibus-emoji-dialog*.vapi does not exist. R=Shawn.P.Huang@gmail.com Committed: aba81ace1487bea57e80406413ae31cbb37ac7d2

Patch Set 1 #

Patch Set 2 : Duplicated gtk+-3.0 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M ui/gtk3/Makefile.am View 1 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 3
fujiwara
6 years, 11 months ago (2017-04-19 06:29:04 UTC) #1
Peng
On 2017/04/19 06:29:04, fujiwara wrote: lgtm
6 years, 11 months ago (2017-04-19 11:29:24 UTC) #2
fujiwara
6 years, 11 months ago (2017-04-20 03:10:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
aba81ace1487bea57e80406413ae31cbb37ac7d2 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b