Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(194)

Issue 323020043: [dfwinreg] Added Windows Registry searcher #52 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by Joachim Metz
Modified:
6 years, 10 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfwinreg] Added Windows Registry searcher #52

Patch Set 1 : Added Windows Registry searcher #

Patch Set 2 : Worked on tests #

Total comments: 20

Patch Set 3 : Changes after review #

Patch Set 4 : Changes after review #

Patch Set 5 : Changes after review #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1415 lines, -250 lines) Patch
M dfwinreg/definitions.py View 1 chunk +2 lines, -0 lines 0 comments Download
M dfwinreg/fake.py View 1 2 12 chunks +22 lines, -35 lines 0 comments Download
M dfwinreg/interface.py View 1 2 18 chunks +52 lines, -101 lines 0 comments Download
A dfwinreg/key_paths.py View 1 2 3 1 chunk +46 lines, -0 lines 0 comments Download
A dfwinreg/py2to3.py View 1 2 1 chunk +16 lines, -0 lines 0 comments Download
M dfwinreg/regf.py View 1 2 9 chunks +11 lines, -13 lines 0 comments Download
M dfwinreg/registry.py View 1 2 12 chunks +70 lines, -14 lines 0 comments Download
A dfwinreg/registry_searcher.py View 1 2 3 4 1 chunk +292 lines, -0 lines 2 comments Download
A dfwinreg/virtual.py View 1 2 1 chunk +236 lines, -0 lines 0 comments Download
M tests/fake.py View 1 10 chunks +48 lines, -41 lines 0 comments Download
A tests/interface.py View 1 2 1 chunk +34 lines, -0 lines 0 comments Download
A tests/key_paths.py View 1 2 3 1 chunk +28 lines, -0 lines 0 comments Download
A tests/py2to3.py View 1 1 chunk +55 lines, -0 lines 0 comments Download
M tests/regf.py View 1 6 chunks +24 lines, -23 lines 0 comments Download
M tests/registry.py View 1 10 chunks +42 lines, -22 lines 0 comments Download
A tests/registry_searcher.py View 1 2 3 1 chunk +185 lines, -0 lines 0 comments Download
A tests/virtual.py View 1 1 chunk +249 lines, -0 lines 0 comments Download
M utils/pylintrc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 18
Joachim Metz
6 years, 10 months ago (2017-05-21 14:41:32 UTC) #1
Joachim Metz
Code updated.
6 years, 10 months ago (2017-05-21 17:25:26 UTC) #2
Joachim Metz
Code updated.
6 years, 10 months ago (2017-05-21 18:57:04 UTC) #3
Joachim Metz
Code updated.
6 years, 10 months ago (2017-05-21 18:57:48 UTC) #4
Joachim Metz
Code updated.
6 years, 10 months ago (2017-05-21 19:02:13 UTC) #5
Joachim Metz
Code updated.
6 years, 10 months ago (2017-05-22 05:49:58 UTC) #6
Joachim Metz
Code updated.
6 years, 10 months ago (2017-05-22 05:58:52 UTC) #7
Joachim Metz
Code updated.
6 years, 10 months ago (2017-05-22 06:46:15 UTC) #8
onager
https://codereview.appspot.com/323020043/diff/130001/dfwinreg/py2to3.py File dfwinreg/py2to3.py (right): https://codereview.appspot.com/323020043/diff/130001/dfwinreg/py2to3.py#newcode2 dfwinreg/py2to3.py:2: """The Python 2 and 3 compatible type definitions.""" -The ...
6 years, 10 months ago (2017-05-26 04:15:34 UTC) #9
Joachim Metz
https://codereview.appspot.com/323020043/diff/130001/dfwinreg/py2to3.py File dfwinreg/py2to3.py (right): https://codereview.appspot.com/323020043/diff/130001/dfwinreg/py2to3.py#newcode2 dfwinreg/py2to3.py:2: """The Python 2 and 3 compatible type definitions.""" On ...
6 years, 10 months ago (2017-05-26 05:57:58 UTC) #10
Joachim Metz
Code updated.
6 years, 10 months ago (2017-05-26 05:58:27 UTC) #11
onager
https://codereview.appspot.com/323020043/diff/130001/dfwinreg/registry_searcher.py File dfwinreg/registry_searcher.py (right): https://codereview.appspot.com/323020043/diff/130001/dfwinreg/registry_searcher.py#newcode183 dfwinreg/registry_searcher.py:183: def Initialize(self): On 2017/05/26 05:57:58, Joachim Metz wrote: > ...
6 years, 10 months ago (2017-05-26 18:44:23 UTC) #12
Joachim Metz
https://codereview.appspot.com/323020043/diff/130001/dfwinreg/registry_searcher.py File dfwinreg/registry_searcher.py (right): https://codereview.appspot.com/323020043/diff/130001/dfwinreg/registry_searcher.py#newcode183 dfwinreg/registry_searcher.py:183: def Initialize(self): On 2017/05/26 18:44:23, onager wrote: > On ...
6 years, 10 months ago (2017-05-27 08:39:15 UTC) #13
Joachim Metz
Code updated.
6 years, 10 months ago (2017-05-27 09:08:05 UTC) #14
Joachim Metz
Code updated.
6 years, 10 months ago (2017-05-27 10:10:33 UTC) #15
onager
LGTM, once the "segements" are removed. https://codereview.appspot.com/323020043/diff/190001/dfwinreg/registry_searcher.py File dfwinreg/registry_searcher.py (right): https://codereview.appspot.com/323020043/diff/190001/dfwinreg/registry_searcher.py#newcode115 dfwinreg/registry_searcher.py:115: search_depth (int): number ...
6 years, 10 months ago (2017-05-29 18:46:17 UTC) #16
Joachim Metz
https://codereview.appspot.com/323020043/diff/190001/dfwinreg/registry_searcher.py File dfwinreg/registry_searcher.py (right): https://codereview.appspot.com/323020043/diff/190001/dfwinreg/registry_searcher.py#newcode115 dfwinreg/registry_searcher.py:115: search_depth (int): number of key path segements to compare. ...
6 years, 10 months ago (2017-05-29 19:01:09 UTC) #17
Joachim Metz
6 years, 10 months ago (2017-05-29 19:01:45 UTC) #18
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close searcher
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b