Issue 322810043: [l2tdevtools] Split rpm and srpm build targets

Issue 322810043: [l2tdevtools] Split rpm and srpm build targets (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 1 month ago by Joachim Metz

Modified:
7 years ago

Reviewers:
jberggren

CC:
kiddi, log2timeline-dev_googlegroups.com, romaing, onager

Visibility:
Public.

More Reviews

Description

[l2tdevtools] Split rpm and srpm build targets

Patch Set 2 : Worked on COPR support in manage script #

Patch Set 3 : Worked on spec file generator #

Total comments: 6

Patch Set 4 : Changes after review #

Created: 7 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1117 lines, -644 lines)			Patch
M	l2tdevtools/build_helper.py	View	1 2 3	23 chunks	+327 lines, -545 lines	0 comments	Download
M	l2tdevtools/dpkg_files.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	l2tdevtools/projects.py	View		1 chunk	+11 lines, -0 lines	0 comments	Download
A	l2tdevtools/spec_file.py	View	1 2 3	1 chunk	+489 lines, -0 lines	0 comments	Download
M	tools/build.py	View		5 chunks	+13 lines, -15 lines	0 comments	Download
M	tools/manage.py	View	1 2	21 chunks	+276 lines, -83 lines	0 comments	Download

Messages

Total messages: 7

Expand All Messages | Collapse All Messages

jberggren

Just some minor nits, otherwise LGTM https://codereview.appspot.com/322810043/diff/40001/l2tdevtools/spec_file.py File l2tdevtools/spec_file.py (right): https://codereview.appspot.com/322810043/diff/40001/l2tdevtools/spec_file.py#newcode52 l2tdevtools/spec_file.py:52: lines = b'' ...

7 years ago (2017-04-01 20:48:18 UTC) #4

Joachim Metz

https://codereview.appspot.com/322810043/diff/40001/l2tdevtools/spec_file.py File l2tdevtools/spec_file.py (right): https://codereview.appspot.com/322810043/diff/40001/l2tdevtools/spec_file.py#newcode52 l2tdevtools/spec_file.py:52: lines = b'' On 2017/04/01 20:48:18, jberggren wrote: > ...

7 years ago (2017-04-02 07:01:58 UTC) #6

Joachim Metz

7 years ago (2017-04-02 07:03:22 UTC) #7

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close srpm

Expand All Messages | Collapse All Messages