Issue 322760043: #12988 Case map utf-8

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 322760043: #12988 Case map utf-8 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 1 month ago by andy.heninger

Modified:
6 years, 8 months ago

Reviewers:
andy.heninger, markus.icu

Base URL:
svn+ssh://source.icu-project.org/repos/icu/trunk/icu4c/

Visibility:
Public.

More Reviews

Patch Set 1 #

Total comments: 2

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+685 lines, -307 lines)			Patch
M	source/common/ucasemap.cpp	View	25 chunks	+354 lines, -200 lines	1 comment	Download
M	source/common/ucasemap_imp.h	View	3 chunks	+6 lines, -3 lines	0 comments	Download
M	source/common/ucasemap_titlecase_brkiter.cpp	View	2 chunks	+35 lines, -1 line	1 comment	Download
M	source/common/unicode/casemap.h	View	5 chunks	+162 lines, -0 lines	0 comments	Download
M	source/common/ustrcase.cpp	View	2 chunks	+13 lines, -10 lines	0 comments	Download
M	source/test/intltest/strcase.cpp	View	14 chunks	+115 lines, -93 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

andy.heninger

LGTM. https://codereview.appspot.com/322760043/diff/1/source/common/ucasemap.cpp File source/common/ucasemap.cpp (right): https://codereview.appspot.com/322760043/diff/1/source/common/ucasemap.cpp#newcode471 source/common/ucasemap.cpp:471: (src[titleStart] == 0x0049 || src[titleStart] == 0x0069)) { ...

7 years, 1 month ago (2017-03-21 20:58:03 UTC) #1

LGTM

Expand All Messages | Collapse All Messages