Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(479)

Issue 322640043: [plaso] Script used to create Jenkins slaves in GCE.

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by romaing
Modified:
1 week, 3 days ago
Reviewers:
onager
CC:
Joachim Metz, jberggren, kiddi, log2timeline-dev_googlegroups.com, aaronp
Visibility:
Public.

Description

[plaso] Script used to create Jenkins slaves in GCE. start_slave.py will be used by the Jenkins master to start new instances (Linux or Windows), replacing the current start-slave.py script. The accompanying bootstrap-vm.ps1 PowerShell script helps install all needed dependencies in a new Windows VM for plaso, as well as the jenkins agent.

Patch Set 1 #

Total comments: 40

Patch Set 2 : Comments #

Patch Set 3 : +pyinstaller #

Total comments: 4

Patch Set 4 : update per comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+453 lines, -0 lines) Patch
A config/jenkins/start_slave.py View 1 2 3 1 chunk +254 lines, -0 lines 0 comments Download
A config/jenkins/windows/bootstrap-vm.ps1 View 1 2 1 chunk +81 lines, -0 lines 0 comments Download
A config/jenkins/windows/bootstrap-vm.ps1.orig View 1 2 1 chunk +118 lines, -0 lines 0 comments Download

Messages

Total messages: 8
onager
https://codereview.appspot.com/322640043/diff/1/config/jenkins/start_slave.py File config/jenkins/start_slave.py (right): https://codereview.appspot.com/322640043/diff/1/config/jenkins/start_slave.py#newcode22 config/jenkins/start_slave.py:22: """Create a new SlaveManager.""" +args https://codereview.appspot.com/322640043/diff/1/config/jenkins/start_slave.py#newcode30 config/jenkins/start_slave.py:30: def _Debug(self, ...
2 months, 1 week ago (2017-09-08 08:36:25 UTC) #1
romaing
https://codereview.appspot.com/322640043/diff/1/config/jenkins/start_slave.py File config/jenkins/start_slave.py (right): https://codereview.appspot.com/322640043/diff/1/config/jenkins/start_slave.py#newcode22 config/jenkins/start_slave.py:22: """Create a new SlaveManager.""" On 2017/09/08 08:36:24, onager wrote: ...
2 months, 1 week ago (2017-09-11 12:06:33 UTC) #2
romaing
Code updated.
2 months, 1 week ago (2017-09-11 12:11:44 UTC) #3
romaing
Code updated.
2 months ago (2017-09-15 12:58:28 UTC) #4
onager
On 2017/09/15 12:58:28, romaing wrote: > Code updated. I think we can get read of ...
1 month, 4 weeks ago (2017-09-21 15:31:06 UTC) #5
onager
https://codereview.appspot.com/322640043/diff/40001/config/jenkins/start_slave.py File config/jenkins/start_slave.py (right): https://codereview.appspot.com/322640043/diff/40001/config/jenkins/start_slave.py#newcode24 config/jenkins/start_slave.py:24: project(str): the GCE project name. + space before the ...
1 month, 4 weeks ago (2017-09-22 08:37:52 UTC) #6
romaing
Code updated.
1 week, 3 days ago (2017-11-09 16:21:31 UTC) #7
romaing
1 week, 3 days ago (2017-11-09 16:21:39 UTC) #8
https://codereview.appspot.com/322640043/diff/40001/config/jenkins/start_slav...
File config/jenkins/start_slave.py (right):

https://codereview.appspot.com/322640043/diff/40001/config/jenkins/start_slav...
config/jenkins/start_slave.py:24: project(str): the GCE project name.
On 2017/09/22 08:37:51, onager wrote:
> + space before the (

Done.

https://codereview.appspot.com/322640043/diff/40001/config/jenkins/start_slav...
config/jenkins/start_slave.py:73: for _pd_name, _device_name in
persistent_disks.items():
On 2017/09/22 08:37:51, onager wrote:
> These don't need underscores - disk_name, device_name is better

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4