Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1407)

Issue 32260044: Adds ellipsis to unit list headers

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 4 months ago by jeff.pihach
Modified:
10 years, 4 months ago
Reviewers:
mp+196622, gary.poster
Visibility:
Public.

Description

Adds ellipsis to unit list headers The unit list headers could overflow pushing the chevron onto the next line when the unit status name is too long. This branch maintains the unit number and chevron in their appropriate places while limiting the length of the unit type when closed. https://code.launchpad.net/~hatch/juju-gui/ellipsis-unit-list/+merge/196622 (do not edit description out of merge proposal)

Patch Set 1 #

Total comments: 3

Patch Set 2 : Adds ellipsis to unit list headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -2 lines) Patch
A [revision details] View 1 1 chunk +2 lines, -0 lines 0 comments Download
M lib/views/juju-inspector.less View 1 2 chunks +30 lines, -2 lines 0 comments Download

Messages

Total messages: 5
jeff.pihach
Please take a look.
10 years, 4 months ago (2013-11-25 20:59:57 UTC) #1
jeff.pihach
reviewer notes https://codereview.appspot.com/32260044/diff/1/lib/views/juju-inspector.less File lib/views/juju-inspector.less (right): https://codereview.appspot.com/32260044/diff/1/lib/views/juju-inspector.less#newcode919 lib/views/juju-inspector.less:919: height: 5px; Magic number increase because the ...
10 years, 4 months ago (2013-11-25 21:02:10 UTC) #2
gary.poster
LGTM with trivial and QA OK. Very cool! Thank you. https://codereview.appspot.com/32260044/diff/1/lib/views/juju-inspector.less File lib/views/juju-inspector.less (right): https://codereview.appspot.com/32260044/diff/1/lib/views/juju-inspector.less#newcode919 ...
10 years, 4 months ago (2013-11-25 21:14:39 UTC) #3
jeff.pihach
Thanks for the review! comment added
10 years, 4 months ago (2013-11-25 21:16:03 UTC) #4
jeff.pihach
10 years, 4 months ago (2013-11-25 21:23:37 UTC) #5
*** Submitted:

Adds ellipsis to unit list headers

The unit list headers could overflow pushing the chevron onto the next line
when the unit status name is too long. This branch maintains the unit number
and chevron in their appropriate places while limiting the length of the
unit type when closed.

R=gary.poster
CC=
https://codereview.appspot.com/32260044
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b