Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(144)

Issue 322500043: ICU ticket #13253: Parameterizes data driven test, replaces encoded characters in test data with Un…

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by nrunge
Modified:
2 months, 1 week ago
Base URL:
svn+ssh://source.icu-project.org/repos/icu/trunk/icu4j/
Visibility:
Public.

Description

ICU ticket #13253: Parameterizes data driven test, replaces encoded characters in test data with Un…

Patch Set 1 #

Total comments: 2

Patch Set 2 : Changes address review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+499 lines, -573 lines) Patch
M main/tests/core/src/com/ibm/icu/dev/test/shaping/ArabicShapingRegTest.java View 11 chunks +10 lines, -573 lines 0 comments Download
A main/tests/core/src/com/ibm/icu/dev/test/shaping/DataDrivenArabicShapingRegTest.java View 1 1 chunk +489 lines, -0 lines 0 comments Download

Messages

Total messages: 5
nrunge
2 months, 2 weeks ago (2017-08-08 15:43:32 UTC) #1
markus.icu
https://codereview.appspot.com/322500043/diff/1/main/tests/core/src/com/ibm/icu/dev/test/shaping/DataDrivenArabicShapingRegTest.java File main/tests/core/src/com/ibm/icu/dev/test/shaping/DataDrivenArabicShapingRegTest.java (right): https://codereview.appspot.com/322500043/diff/1/main/tests/core/src/com/ibm/icu/dev/test/shaping/DataDrivenArabicShapingRegTest.java#newcode62 main/tests/core/src/com/ibm/icu/dev/test/shaping/DataDrivenArabicShapingRegTest.java:62: @Parameterized.Parameters funky indentation Try to avoid the Eclipse auto-formatter... ...
2 months, 2 weeks ago (2017-08-08 23:13:41 UTC) #2
nrunge
Changes address review comments
2 months, 2 weeks ago (2017-08-09 19:36:57 UTC) #3
nrunge
On 2017/08/08 23:13:41, markus.icu wrote: > https://codereview.appspot.com/322500043/diff/1/main/tests/core/src/com/ibm/icu/dev/test/shaping/DataDrivenArabicShapingRegTest.java > File > main/tests/core/src/com/ibm/icu/dev/test/shaping/DataDrivenArabicShapingRegTest.java > (right): > > ...
2 months, 2 weeks ago (2017-08-09 19:43:57 UTC) #4
markus.icu
2 months, 1 week ago (2017-08-17 22:02:10 UTC) #5
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted