Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(185)

Issue 322490043: [plaso] Added Linux system product preprocessor plugin #1337

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 week, 5 days ago by Joachim Metz
Modified:
2 days, 7 hours ago
Reviewers:
aaronp
CC:
jberggren, romaing, onager, kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[plaso] Added Linux system product preprocessor plugin #1337 Dependent on: https://github.com/ForensicArtifacts/artifacts/pull/234

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -67 lines) Patch
M plaso/preprocessors/linux.py View 2 chunks +40 lines, -1 line 2 comments Download
M plaso/preprocessors/windows.py View 19 chunks +41 lines, -37 lines 2 comments Download
M test_data/artifacts/artifacts.yaml View 1 chunk +32 lines, -0 lines 0 comments Download
M tests/preprocessors/linux.py View 1 chunk +20 lines, -0 lines 0 comments Download
M tests/preprocessors/windows.py View 8 chunks +31 lines, -29 lines 0 comments Download

Messages

Total messages: 4
Joachim Metz
1 week, 5 days ago (2017-08-08 06:51:05 UTC) #1
aaronp
https://codereview.appspot.com/322490043/diff/1/plaso/preprocessors/linux.py File plaso/preprocessors/linux.py (right): https://codereview.appspot.com/322490043/diff/1/plaso/preprocessors/linux.py#newcode80 plaso/preprocessors/linux.py:80: system_product = text_file_object.readline() This seems like it will work ...
1 week, 2 days ago (2017-08-10 17:31:25 UTC) #2
Joachim Metz
https://codereview.appspot.com/322490043/diff/1/plaso/preprocessors/linux.py File plaso/preprocessors/linux.py (right): https://codereview.appspot.com/322490043/diff/1/plaso/preprocessors/linux.py#newcode80 plaso/preprocessors/linux.py:80: system_product = text_file_object.readline() Thx for flagging. Now I think ...
1 week, 2 days ago (2017-08-11 06:09:19 UTC) #3
Joachim Metz
2 days, 7 hours ago (2017-08-18 06:28:44 UTC) #4
Splitting LSB and non-LSB release information across multiple artifacts:
https://github.com/ForensicArtifacts/artifacts/pull/234
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted