Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(10522)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 322320043: [dfvfs] Made Unicode strings the default #204 and updated docstrings #182 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by Joachim Metz
Modified:
6 years, 9 months ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[dfvfs] Made Unicode strings the default #204 and updated docstrings #182

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+497 lines, -412 lines) Patch
M dfvfs/vfs/bde_file_entry.py View 2 chunks +3 lines, -1 line 0 comments Download
M dfvfs/vfs/bde_file_system.py View 2 chunks +3 lines, -1 line 0 comments Download
M dfvfs/vfs/compressed_stream_file_entry.py View 2 chunks +3 lines, -1 line 0 comments Download
M dfvfs/vfs/compressed_stream_file_system.py View 2 chunks +5 lines, -3 lines 0 comments Download
M dfvfs/vfs/cpio_file_entry.py View 8 chunks +19 lines, -17 lines 0 comments Download
M dfvfs/vfs/cpio_file_system.py View 5 chunks +7 lines, -5 lines 0 comments Download
M dfvfs/vfs/data_range_file_entry.py View 1 chunk +2 lines, -0 lines 0 comments Download
M dfvfs/vfs/data_range_file_system.py View 2 chunks +7 lines, -5 lines 0 comments Download
M dfvfs/vfs/encoded_stream_file_entry.py View 2 chunks +3 lines, -1 line 0 comments Download
M dfvfs/vfs/encoded_stream_file_system.py View 2 chunks +5 lines, -3 lines 0 comments Download
M dfvfs/vfs/encrypted_stream_file_entry.py View 2 chunks +3 lines, -1 line 0 comments Download
M dfvfs/vfs/encrypted_stream_file_system.py View 2 chunks +5 lines, -3 lines 0 comments Download
M dfvfs/vfs/fake_file_entry.py View 9 chunks +13 lines, -11 lines 0 comments Download
M dfvfs/vfs/fake_file_system.py View 7 chunks +10 lines, -8 lines 0 comments Download
M dfvfs/vfs/file_entry.py View 8 chunks +11 lines, -9 lines 0 comments Download
M dfvfs/vfs/file_system.py View 7 chunks +13 lines, -11 lines 0 comments Download
M dfvfs/vfs/fvde_file_entry.py View 2 chunks +3 lines, -1 line 0 comments Download
M dfvfs/vfs/fvde_file_system.py View 2 chunks +3 lines, -1 line 0 comments Download
M dfvfs/vfs/gzip_file_entry.py View 2 chunks +3 lines, -1 line 0 comments Download
M dfvfs/vfs/gzip_file_system.py View 1 chunk +2 lines, -0 lines 0 comments Download
M dfvfs/vfs/lvm_file_entry.py View 6 chunks +11 lines, -9 lines 0 comments Download
M dfvfs/vfs/lvm_file_system.py View 4 chunks +5 lines, -3 lines 0 comments Download
M dfvfs/vfs/ntfs_file_entry.py View 14 chunks +19 lines, -17 lines 0 comments Download
M dfvfs/vfs/ntfs_file_system.py View 7 chunks +15 lines, -13 lines 0 comments Download
M dfvfs/vfs/os_file_entry.py View 11 chunks +15 lines, -13 lines 0 comments Download
M dfvfs/vfs/os_file_system.py View 10 chunks +25 lines, -23 lines 0 comments Download
M dfvfs/vfs/root_only_file_entry.py View 2 chunks +3 lines, -1 line 0 comments Download
M dfvfs/vfs/root_only_file_system.py View 2 chunks +3 lines, -1 line 0 comments Download
M dfvfs/vfs/tar_file_entry.py View 8 chunks +22 lines, -20 lines 0 comments Download
M dfvfs/vfs/tar_file_system.py View 6 chunks +9 lines, -7 lines 0 comments Download
M dfvfs/vfs/tsk_file_entry.py View 25 chunks +68 lines, -66 lines 0 comments Download
M dfvfs/vfs/tsk_file_system.py View 8 chunks +15 lines, -13 lines 0 comments Download
M dfvfs/vfs/tsk_partition_file_entry.py View 5 chunks +12 lines, -10 lines 0 comments Download
M dfvfs/vfs/tsk_partition_file_system.py View 6 chunks +7 lines, -5 lines 0 comments Download
M dfvfs/vfs/vfs_stat.py View 1 chunk +2 lines, -0 lines 0 comments Download
M dfvfs/vfs/vshadow_file_entry.py View 5 chunks +10 lines, -8 lines 0 comments Download
M dfvfs/vfs/vshadow_file_system.py View 5 chunks +6 lines, -4 lines 0 comments Download
M dfvfs/vfs/zip_file_entry.py View 12 chunks +21 lines, -19 lines 0 comments Download
M dfvfs/vfs/zip_file_system.py View 7 chunks +13 lines, -11 lines 0 comments Download
M dfvfs/volume/lvm_volume_system.py View 6 chunks +12 lines, -10 lines 0 comments Download
M dfvfs/volume/tsk_volume_system.py View 5 chunks +19 lines, -16 lines 0 comments Download
M dfvfs/volume/volume_system.py View 18 chunks +47 lines, -47 lines 0 comments Download
M dfvfs/volume/vshadow_volume_system.py View 7 chunks +15 lines, -13 lines 0 comments Download

Messages

Total messages: 3
Joachim Metz
6 years, 9 months ago (2017-07-16 07:40:26 UTC) #1
onager
LGTM
6 years, 9 months ago (2017-07-18 14:40:57 UTC) #2
Joachim Metz
6 years, 9 months ago (2017-07-18 18:33:16 UTC) #3 
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close unicode7
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b