Issue 322030043: [l2tdevtools] Several fixes for missing project version

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 322030043: [l2tdevtools] Several fixes for missing project version (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 10 months ago by Joachim Metz

Modified:
6 years, 10 months ago

Reviewers:
jberggren

CC:
kiddi, log2timeline-dev_googlegroups.com, onager

Visibility:
Public.

[l2tdevtools] Several fixes for missing project version

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -35 lines)			Patch
A +	data/licenses/LICENSE.astroid	View	1	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	data/licenses/LICENSE.pylint	View	1	10 chunks	+21 lines, -20 lines	0 comments	Download
M	data/presets.ini	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	data/projects.ini	View	1	5 chunks	+27 lines, -2 lines	0 comments	Download
M	l2tdevtools/build_helper.py	View	1 2	5 chunks	+14 lines, -4 lines	0 comments	Download
M	l2tdevtools/dpkg_files.py	View	1 2	4 chunks	+5 lines, -2 lines	0 comments	Download
M	l2tdevtools/spec_file.py	View		1 chunk	+8 lines, -3 lines	0 comments	Download
M	utils/pylintrc	View	1 2	2 chunks	+9 lines, -4 lines	0 comments	Download

Total messages: 5

jberggren

On 2017/06/10 23:10:26, Joachim Metz wrote: > Code updated. LGTM Sorry for the delay.

6 years, 10 months ago (2017-06-21 03:06:09 UTC) #4

Joachim Metz

6 years, 10 months ago (2017-06-21 04:38:43 UTC) #5

Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close fixes