Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(483)

Issue 321610043: ui/gtk3: Fix SEGV in IBusEmojier.get_selected_string

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 1 week ago by fujiwara
Modified:
2 months, 1 week ago
Reviewers:
shawn.p.huang
CC:
fujiwara
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

ui/gtk3: Fix SEGV in IBusEmojier.get_selected_string BUG=RHBZ#1489537

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M ui/gtk3/emojier.vala View 2 chunks +11 lines, -3 lines 3 comments Download
M ui/gtk3/switcher.vala View 2 chunks +10 lines, -0 lines 1 comment Download

Messages

Total messages: 4
fujiwara
2 months, 1 week ago (2017-09-08 06:12:31 UTC) #1
Peng
https://codereview.appspot.com/321610043/diff/1/ui/gtk3/emojier.vala File ui/gtk3/emojier.vala (right): https://codereview.appspot.com/321610043/diff/1/ui/gtk3/emojier.vala#newcode1566 ui/gtk3/emojier.vala:1566: if (!(this is IBusEmojier)) why we need it? https://codereview.appspot.com/321610043/diff/1/ui/gtk3/switcher.vala ...
2 months, 1 week ago (2017-09-08 15:09:56 UTC) #2
fujiwara
https://codereview.appspot.com/321610043/diff/1/ui/gtk3/emojier.vala File ui/gtk3/emojier.vala (right): https://codereview.appspot.com/321610043/diff/1/ui/gtk3/emojier.vala#newcode1566 ui/gtk3/emojier.vala:1566: if (!(this is IBusEmojier)) On 2017/09/08 15:09:56, Peng wrote: ...
2 months, 1 week ago (2017-09-11 03:17:28 UTC) #3
Peng
2 months, 1 week ago (2017-09-11 13:50:30 UTC) #4
https://codereview.appspot.com/321610043/diff/1/ui/gtk3/emojier.vala
File ui/gtk3/emojier.vala (right):

https://codereview.appspot.com/321610043/diff/1/ui/gtk3/emojier.vala#newcode1566
ui/gtk3/emojier.vala:1566: if (!(this is IBusEmojier))
On 2017/09/11 03:17:28, fujiwara wrote:
> On 2017/09/08 15:09:56, Peng wrote:
> > why we need it?
> 
> Because the focus in event can be called before either emojier instructor is
> completed or destructor is completed.
> You could see the backtrace of the original bug.

I feel it is not right to call an object method before construction or after
destruction. It must be a bug in other place. It is not good to test it here.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld c59f3c4