Issue 321610043: ui/gtk3: Fix SEGV in IBusEmojier.get_selected_string

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 321610043: ui/gtk3: Fix SEGV in IBusEmojier.get_selected_string

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 7 months ago by fujiwara

Modified:
6 years, 7 months ago

Reviewers:
shawn.p.huang

CC:
fujiwara

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

ui/gtk3: Fix SEGV in IBusEmojier.get_selected_string BUG=RHBZ#1489537

Patch Set 1 #

Total comments: 4

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -3 lines)			Patch
	M	ui/gtk3/emojier.vala	View		2 chunks	+11 lines, -3 lines	3 comments	Download
	M	ui/gtk3/switcher.vala	View		2 chunks	+10 lines, -0 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

https://codereview.appspot.com/321610043/diff/1/ui/gtk3/emojier.vala File ui/gtk3/emojier.vala (right): https://codereview.appspot.com/321610043/diff/1/ui/gtk3/emojier.vala#newcode1566 ui/gtk3/emojier.vala:1566: if (!(this is IBusEmojier)) why we need it? https://codereview.appspot.com/321610043/diff/1/ui/gtk3/switcher.vala ...

6 years, 7 months ago (2017-09-08 15:09:56 UTC) #2

fujiwara

6 years, 7 months ago (2017-09-11 03:17:28 UTC) #3

Peng

6 years, 7 months ago (2017-09-11 13:50:30 UTC) #4

https://codereview.appspot.com/321610043/diff/1/ui/gtk3/emojier.vala
File ui/gtk3/emojier.vala (right):

https://codereview.appspot.com/321610043/diff/1/ui/gtk3/emojier.vala#newcode1566
ui/gtk3/emojier.vala:1566: if (!(this is IBusEmojier))
On 2017/09/11 03:17:28, fujiwara wrote:
> On 2017/09/08 15:09:56, Peng wrote:
> > why we need it?
> 
> Because the focus in event can be called before either emojier instructor is
> completed or destructor is completed.
> You could see the backtrace of the original bug.

I feel it is not right to call an object method before construction or after
destruction. It must be a bug in other place. It is not good to test it here.

Expand All Messages | Collapse All Messages