Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1121)

Issue 321460043: Issue 1434: Fix text spacing in SVG (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 8 months ago by Ebe123
Modified:
6 years, 8 months ago
Reviewers:
pkx, dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 1434: Fix text spacing in SVG This change makes every SVG contain a style tag with the `white-space` property set to include all white-space (`pre`). This will cause all white-space to be applied, and not be ignored. As SVG files with `-dsvg-woff` set already appended a style tag, the woff-header now only appends their settings, with a new define to close the style tag. The main difficulty arising with this change was with the newline character that appears after each opening tag. To rectify, a boolean parameter was added to define(s) on whether to insert a newline for opening tags, and the appropriate value was passed to all uses of the define(s).

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -41 lines) Patch
M scm/framework-svg.scm View 4 chunks +23 lines, -19 lines 0 comments Download
M scm/output-svg.scm View 17 chunks +24 lines, -22 lines 0 comments Download

Messages

Total messages: 1
Ebe123
6 years, 8 months ago (2017-08-18 03:54:19 UTC) #1
This patch provides a more thorough solution to the spacing problem than my
other patch, specifically for metronome marks:
https://codereview.appspot.com/323420043/ .
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b