Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(622)

Issue 321430043: Self_alignment_interface::aligned_on_self: bad warning

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months ago by dak
Modified:
4 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Self_alignment_interface::aligned_on_self: bad warning " has empty extent and non-empty stencil." did not actually check for a non-empty stencil.

Patch Set 1 #

Patch Set 2 : Overlooked another warning. #

Patch Set 3 : Thinko: we still need to check the stencil for 0 even if not the grob #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M lily/self-alignment-interface.cc View 1 2 4 chunks +19 lines, -6 lines 0 comments Download

Messages

Total messages: 2
dak
Overlooked another warning.
4 months ago (2017-08-08 13:52:27 UTC) #1
dak
4 months ago (2017-08-09 20:13:22 UTC) #2
Thinko: we still need to check the stencil for 0 even if not the grob
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 204d58d