Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(567)

Issue 321340043: [l2tdevtools] Changes for pylint 1.7 upgrade #163 and making Unicode strings the default #151 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 9 months ago by Joachim Metz
Modified:
6 years, 8 months ago
Reviewers:
onager
CC:
jberggren, kiddi, log2timeline-dev_googlegroups.com
Visibility:
Public.

Description

[l2tdevtools] Changes for pylint 1.7 upgrade #163 and making Unicode strings the default #151

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1127 lines, -890 lines) Patch
M l2tdevtools/build_helper.py View 119 chunks +595 lines, -592 lines 0 comments Download
M l2tdevtools/dependencies.py View 1 chunk +2 lines, -0 lines 0 comments Download
M l2tdevtools/download_helper.py View 4 chunks +16 lines, -6 lines 0 comments Download
M l2tdevtools/presets.py View 2 chunks +9 lines, -3 lines 0 comments Download
M l2tdevtools/project_config.py View 3 chunks +11 lines, -8 lines 0 comments Download
M l2tdevtools/projects.py View 5 chunks +63 lines, -56 lines 0 comments Download
A l2tdevtools/py2to3.py View 1 chunk +18 lines, -0 lines 0 comments Download
M l2tdevtools/source_helper.py View 9 chunks +47 lines, -45 lines 0 comments Download
M l2tdevtools/spec_file.py View 15 chunks +37 lines, -35 lines 0 comments Download
M tests/download_helper.py View 2 chunks +4 lines, -1 line 0 comments Download
M utils/pylintrc View 5 chunks +325 lines, -144 lines 2 comments Download

Messages

Total messages: 5
Joachim Metz
6 years, 9 months ago (2017-07-26 06:24:56 UTC) #1
onager
https://codereview.appspot.com/321340043/diff/1/utils/pylintrc File utils/pylintrc (right): https://codereview.appspot.com/321340043/diff/1/utils/pylintrc#newcode200 utils/pylintrc:200: argument-name-hint=(([a-z][a-z0-9_]*)|(_[a-z0-9_]*))$ The default looks better to me here - ...
6 years, 8 months ago (2017-08-04 10:04:36 UTC) #2
onager
On 2017/08/04 10:04:36, onager wrote: > https://codereview.appspot.com/321340043/diff/1/utils/pylintrc > File utils/pylintrc (right): > > https://codereview.appspot.com/321340043/diff/1/utils/pylintrc#newcode200 > ...
6 years, 8 months ago (2017-08-04 10:05:04 UTC) #3
Joachim Metz
https://codereview.appspot.com/321340043/diff/1/utils/pylintrc File utils/pylintrc (right): https://codereview.appspot.com/321340043/diff/1/utils/pylintrc#newcode200 utils/pylintrc:200: argument-name-hint=(([a-z][a-z0-9_]*)|(_[a-z0-9_]*))$ On 2017/08/04 10:04:36, onager wrote: > The default ...
6 years, 8 months ago (2017-08-05 05:50:51 UTC) #4
Joachim Metz
6 years, 8 months ago (2017-08-05 06:28:54 UTC) #5
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close pylint
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b