Issue 321150043: ICU ticket #13242: changes locale to da in an uppercase-come-first collation ICU4C test and re-enab…

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 321150043: ICU ticket #13242: changes locale to da in an uppercase-come-first collation ICU4C test and re-enab… (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
6 years, 10 months ago by nrunge

Modified:
6 years, 8 months ago

Reviewers:
andy.heninger, markus.icu

CC:
yoshito_umaoka_us.ibm.com, nrunge

Base URL:
svn+ssh://source.icu-project.org/repos/icu/trunk/icu4c/

Visibility:
Public.

More Reviews

Description

ICU ticket #13242: changes locale to da in an uppercase-come-first collation ICU4C test and re-enab…

Patch Set 2 : codereview changes #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	source/test/cintltst/cmsccoll.c	View	1	3 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

andy.heninger

https://codereview.appspot.com/321150043/diff/1/source/test/cintltst/cmsccoll.c File source/test/cintltst/cmsccoll.c (right): https://codereview.appspot.com/321150043/diff/1/source/test/cintltst/cmsccoll.c#newcode5894 source/test/cintltst/cmsccoll.c:5894: TEST(TestJ831); /* we changed lv locale */ Could remove ...

6 years, 10 months ago (2017-06-20 22:43:28 UTC) #2

nrunge

6 years, 10 months ago (2017-06-20 22:53:21 UTC) #4

markus.icu

6 years, 10 months ago (2017-06-21 05:46:24 UTC) #6

LGTM

It would be even nicer if the C and Java test functions had the same names.

Expand All Messages | Collapse All Messages