Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(198)

Issue 321000043: [plaso] Refactored log2timeline front-end to tool #160 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month, 1 week ago by Joachim Metz
Modified:
3 weeks, 4 days ago
Reviewers:
onager
CC:
kiddi, log2timeline-dev_googlegroups.com, jberggren, romaing
Visibility:
Public.

Description

[plaso] Refactored log2timeline front-end to tool #160

Patch Set 1 : Updated review script #

Total comments: 10

Patch Set 2 : Changes after review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1422 lines, -5694 lines) Patch
M plaso/cli/extraction_tool.py View 1 11 chunks +155 lines, -38 lines 0 comments Download
A + plaso/cli/image_export_tool.py View 2 chunks +1 line, -48 lines 0 comments Download
A + plaso/cli/log2timeline_tool.py View 1 13 chunks +312 lines, -210 lines 0 comments Download
A plaso/cli/logging_filter.py View 1 chunk +25 lines, -0 lines 0 comments Download
A + plaso/cli/pinfo_tool.py View 3 chunks +5 lines, -37 lines 0 comments Download
A + plaso/cli/psort_tool.py View 2 chunks +1 line, -61 lines 0 comments Download
A + plaso/cli/psteal_tool.py View 1 8 chunks +128 lines, -122 lines 0 comments Download
M plaso/cli/status_view_tool.py View 2 chunks +1 line, -9 lines 0 comments Download
M plaso/cli/tools.py View 2 chunks +31 lines, -1 line 0 comments Download
M plaso/engine/engine.py View 5 chunks +34 lines, -3 lines 0 comments Download
M plaso/engine/worker.py View 2 chunks +2 lines, -2 lines 0 comments Download
M plaso/frontend/extraction_frontend.py View 1 8 chunks +11 lines, -190 lines 0 comments Download
D plaso/frontend/log2timeline.py View 1 chunk +0 lines, -105 lines 0 comments Download
M plaso/output/manager.py View 1 chunk +1 line, -1 line 0 comments Download
M plaso/parsers/manager.py View 3 chunks +72 lines, -10 lines 0 comments Download
M run_tests.py View 1 chunk +0 lines, -6 lines 0 comments Download
D test_data/artifacts.yaml View 1 chunk +0 lines, -21 lines 0 comments Download
A + test_data/artifacts/artifacts.yaml View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/analyzers/hashers/manager.py View 1 chunk +10 lines, -0 lines 0 comments Download
M tests/cli/extract_analyze_tool.py View 1 chunk +5 lines, -10 lines 0 comments Download
M tests/cli/extraction_tool.py View 1 4 chunks +149 lines, -8 lines 0 comments Download
A + tests/cli/image_export_tool.py View 4 chunks +14 lines, -15 lines 0 comments Download
A + tests/cli/log2timeline_tool.py View 20 chunks +140 lines, -142 lines 0 comments Download
A + tests/cli/pinfo_tool.py View 8 chunks +19 lines, -20 lines 0 comments Download
A + tests/cli/psort_tool.py View 13 chunks +29 lines, -30 lines 0 comments Download
A + tests/cli/psteal_tool.py View 12 chunks +31 lines, -32 lines 0 comments Download
M tests/cli/tools.py View 1 chunk +33 lines, -0 lines 0 comments Download
M tests/engine/engine.py View 1 chunk +3 lines, -0 lines 0 comments Download
M tests/frontend/extraction_frontend.py View 2 chunks +0 lines, -56 lines 0 comments Download
D tests/frontend/log2timeline.py View 1 chunk +0 lines, -76 lines 0 comments Download
M tests/parsers/manager.py View 4 chunks +51 lines, -22 lines 0 comments Download
M tools/image_export.py View 1 chunk +3 lines, -275 lines 0 comments Download
D tools/image_export_test.py View 1 chunk +0 lines, -107 lines 0 comments Download
M tools/log2timeline.py View 2 chunks +3 lines, -616 lines 0 comments Download
D tools/log2timeline_test.py View 1 chunk +0 lines, -462 lines 0 comments Download
M tools/pinfo.py View 1 chunk +2 lines, -610 lines 0 comments Download
D tools/pinfo_test.py View 1 chunk +0 lines, -250 lines 0 comments Download
M tools/psort.py View 2 chunks +2 lines, -845 lines 0 comments Download
D tools/psort_test.py View 1 chunk +0 lines, -508 lines 0 comments Download
M tools/psteal.py View 1 chunk +2 lines, -364 lines 0 comments Download
D tools/psteal_test.py View 1 chunk +0 lines, -313 lines 0 comments Download
M utils/review.py View 35 chunks +148 lines, -70 lines 0 comments Download

Messages

Total messages: 9
Joachim Metz
1 month, 1 week ago (2017-05-14 18:28:54 UTC) #1
Joachim Metz
Code updated.
1 month, 1 week ago (2017-05-15 04:42:07 UTC) #2
Joachim Metz
Code updated.
1 month, 1 week ago (2017-05-16 04:51:32 UTC) #3
Joachim Metz
Code updated.
1 month ago (2017-05-20 05:36:25 UTC) #4
onager
https://codereview.appspot.com/321000043/diff/60001/plaso/cli/extraction_tool.py File plaso/cli/extraction_tool.py (right): https://codereview.appspot.com/321000043/diff/60001/plaso/cli/extraction_tool.py#newcode238 plaso/cli/extraction_tool.py:238: u'Path to a directory containing artifact definitions.')) Please add ...
4 weeks ago (2017-05-26 23:53:47 UTC) #5
Joachim Metz
https://codereview.appspot.com/321000043/diff/60001/plaso/cli/extraction_tool.py File plaso/cli/extraction_tool.py (right): https://codereview.appspot.com/321000043/diff/60001/plaso/cli/extraction_tool.py#newcode238 plaso/cli/extraction_tool.py:238: u'Path to a directory containing artifact definitions.')) On 2017/05/26 ...
4 weeks ago (2017-05-27 07:01:36 UTC) #6
Joachim Metz
Code updated.
4 weeks ago (2017-05-27 07:16:41 UTC) #7
onager
LGTM
3 weeks, 4 days ago (2017-05-29 18:59:16 UTC) #8
Joachim Metz
3 weeks, 4 days ago (2017-05-29 19:38:25 UTC) #9
Changes have been merged with master branch. To close the review and clean up
the feature branch you can run: python ./utils/review.py close cleanup
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted