Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(109)

Issue 320820043: Add a \voicify command

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months, 3 weeks ago by dak
Modified:
6 months, 2 weeks ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add a \voicify command Also contains commits: Document \voicify Add regtest for \voicify Let voicify-music receive an optional id list

Patch Set 1 #

Patch Set 2 : Actual patch after establish issue 5113 baseline in patch set 1 #

Total comments: 1

Patch Set 3 : Fix documentation problems (and some formatting) #

Total comments: 2

Patch Set 4 : Fix the error behavior, rename \voicify to \voices #

Patch Set 5 : Fix stupid blunder/omission #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -36 lines) Patch
M Documentation/learning/fundamental.itely View 1 2 3 8 chunks +58 lines, -7 lines 0 comments Download
M Documentation/notation/simultaneous.itely View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
A input/regression/voices-command.ly View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
M ly/music-functions-init.ly View 1 2 3 1 chunk +22 lines, -0 lines 0 comments Download
M scm/music-functions.scm View 1 2 3 4 1 chunk +61 lines, -29 lines 0 comments Download

Messages

Total messages: 17
dak
Actual patch after establish issue 5113 baseline in patch set 1
6 months, 3 weeks ago (2017-04-03 08:46:14 UTC) #1
lemzwerg
Very nice!
6 months, 3 weeks ago (2017-04-03 09:18:47 UTC) #2
pkx166h
Fails make doc. https://codereview.appspot.com/320820043/diff/20001/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/320820043/diff/20001/ly/music-functions-init.ly#newcode2007 ly/music-functions-init.ly:2007: \\voicify 1,2,3 << @dots {} \\\\ ...
6 months, 3 weeks ago (2017-04-03 17:39:55 UTC) #3
dak
On 2017/04/03 17:39:55, pkx166h wrote: > Fails make doc. > > https://codereview.appspot.com/320820043/diff/20001/ly/music-functions-init.ly > File ly/music-functions-init.ly ...
6 months, 3 weeks ago (2017-04-03 17:43:18 UTC) #4
dak
Fix documentation problems (and some formatting)
6 months, 3 weeks ago (2017-04-03 18:11:21 UTC) #5
Trevor Daniels
LGTM David, you've found an excellent way of squaring the circle! Trevor
6 months, 2 weeks ago (2017-04-06 14:29:58 UTC) #6
thomasmorley651
Great! Two thoughts: (1) it's a common request on the user list how to continue ...
6 months, 2 weeks ago (2017-04-08 12:02:45 UTC) #7
thomasmorley651
https://codereview.appspot.com/320820043/diff/40001/scm/music-functions.scm File scm/music-functions.scm (right): https://codereview.appspot.com/320820043/diff/40001/scm/music-functions.scm#newcode968 scm/music-functions.scm:968: On 2017/04/08 12:02:45, thomasmorley651 wrote: > Why not throw ...
6 months, 2 weeks ago (2017-04-08 12:26:15 UTC) #8
dak
thomasmorley65@gmail.com writes: > Great! > > Two thoughts: > > (1) > it's a common ...
6 months, 2 weeks ago (2017-04-09 15:13:32 UTC) #9
dak
thomasmorley65@gmail.com writes: > https://codereview.appspot.com/320820043/diff/40001/scm/music-functions.scm > File scm/music-functions.scm (right): > > https://codereview.appspot.com/320820043/diff/40001/scm/music-functions.scm#newcode968 > scm/music-functions.scm:968: > On ...
6 months, 2 weeks ago (2017-04-09 15:15:47 UTC) #10
thomasmorley651
On 2017/04/09 15:15:47, dak wrote: > mailto:thomasmorley65@gmail.com writes: > > > https://codereview.appspot.com/320820043/diff/40001/scm/music-functions.scm > > File ...
6 months, 2 weeks ago (2017-04-09 18:36:00 UTC) #11
thomasmorley651
On 2017/04/09 15:13:32, dak wrote: > mailto:thomasmorley65@gmail.com writes: > > > Great! > > > ...
6 months, 2 weeks ago (2017-04-09 18:38:16 UTC) #12
dak
thomasmorley65@gmail.com writes: > I then would have expected the following to work (with a warning): ...
6 months, 2 weeks ago (2017-04-09 18:50:01 UTC) #13
dak
David Kastrup <dak@gnu.org> writes: > thomasmorley65@gmail.com writes: > >> I then would have expected the ...
6 months, 2 weeks ago (2017-04-09 19:25:10 UTC) #14
dak
Fix the error behavior, rename \voicify to \voices
6 months, 2 weeks ago (2017-04-09 20:30:45 UTC) #15
thomasmorley651
On 2017/04/09 20:30:45, dak wrote: > Fix the error behavior, rename \voicify to \voices Error ...
6 months, 2 weeks ago (2017-04-10 09:12:47 UTC) #16
dak
6 months, 2 weeks ago (2017-04-11 16:26:24 UTC) #17
Fix stupid blunder/omission
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted