Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(40)

Issue 320700043: ui/gtk3: Integrate custom rendering to use HarfBuzz glyph info

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 month ago by fujiwara
Modified:
1 week, 2 days ago
Reviewers:
shawn.p.huang, Peng
CC:
fujiwara, Peng Wu
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

ui/gtk3: Integrate custom rendering to use HarfBuzz glyph info IBusFontSet offers FcFontSet, glyph info with HarfBuzz and rendering on Cairo context. Current Pango changes fonts by emoji variants and draws the separated glyphs [1] but actually the emoji characters with variants can be drawn as one glyph so this class manages Fontconfig fontsets to select a font, HarfBuzz to get glyphs for emoji variants, Cairo to draw glyphs. Need configure --enable-harfbuzz-for-emoji option to enable this feature. [1]: https://bugzilla.gnome.org/show_bug.cgi?id=780669 https://bugzilla.gnome.org/show_bug.cgi?id=781123 BUG=https://bugzilla.gnome.org/show_bug.cgi?id=780669

Patch Set 1 #

Patch Set 2 : Fix a typo #

Patch Set 3 : Show code points for ASCII control chars. #

Patch Set 4 : Fix ln failure in parallel make #

Patch Set 5 : Fixed some memory leaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1685 lines, -114 lines) Patch
A + bindings/vala/IBusEmojiDialog-1.0.metadata View 0 chunks +-1 lines, --1 lines 0 comments Download
A bindings/vala/IBusFontSet-1.0.metadata View 1 chunk +1 line, -0 lines 0 comments Download
M bindings/vala/Makefile.am View 1 2 3 3 chunks +230 lines, -14 lines 0 comments Download
A + bindings/vala/ibus-emoji-dialog-1.0.deps View 0 chunks +-1 lines, --1 lines 0 comments Download
A bindings/vala/ibus-fontset-1.0.deps View 1 chunk +1 line, -0 lines 0 comments Download
M configure.ac View 2 chunks +29 lines, -0 lines 0 comments Download
M po/POTFILES.skip View 1 chunk +5 lines, -0 lines 0 comments Download
M src/ibusemoji.c View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
D ui/gtk3/IBusEmojiDialog-1.0.metadata View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gtk3/Makefile.am View 4 chunks +50 lines, -81 lines 0 comments Download
M ui/gtk3/emojier.vala View 1 2 3 4 19 chunks +119 lines, -18 lines 0 comments Download
D ui/gtk3/ibus-emoji-dialog-1.0.deps View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/gtk3/ibusemojidialog.h View 1 chunk +26 lines, -0 lines 0 comments Download
A ui/gtk3/ibusfontset.h View 1 chunk +302 lines, -0 lines 0 comments Download
A ui/gtk3/ibusfontset.c View 1 2 3 4 1 chunk +923 lines, -0 lines 0 comments Download

Messages

Total messages: 2
fujiwara
1 month ago (2017-06-24 07:53:48 UTC) #1
Peng
4 weeks, 1 day ago (2017-06-28 02:55:12 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted