Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3407)

Issue 320680043: ticket:12690 Adding convenience overloads for java.util.Currency. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 10 months ago by sffc
Modified:
6 years, 9 months ago
Reviewers:
andy.heninger
Base URL:
svn+icussh://source.icu-project.org/repos/icu/trunk/
Visibility:
Public.

Description

ticket:12690 Adding convenience overloads for java.util.Currency.

Patch Set 1 #

Patch Set 2 : Adding unit test coverage for new methods. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -5 lines) Patch
M icu4j/main/classes/core/src/com/ibm/icu/util/Currency.java View 1 1 chunk +21 lines, -0 lines 0 comments Download
M icu4j/main/classes/core/src/com/ibm/icu/util/CurrencyAmount.java View 1 2 chunks +23 lines, -3 lines 0 comments Download
M icu4j/main/tests/core/src/com/ibm/icu/dev/test/format/NumberFormatTest.java View 1 2 chunks +18 lines, -2 lines 0 comments Download

Messages

Total messages: 6
sffc
See corresponding API proposal.
6 years, 10 months ago (2017-06-21 01:47:47 UTC) #1
andy.heninger
Need to add tests that call the new functions.
6 years, 10 months ago (2017-06-22 18:57:54 UTC) #2
sffc
Adding unit test coverage for new methods.
6 years, 10 months ago (2017-06-22 22:24:19 UTC) #3
sffc
Added unit tests.
6 years, 10 months ago (2017-06-22 22:25:09 UTC) #4
andy.heninger
LGTM
6 years, 9 months ago (2017-06-26 22:11:13 UTC) #5
sffc
6 years, 9 months ago (2017-07-11 17:24:47 UTC) #6
On 2017/06/26 22:11:13, andy.heninger wrote:
> LGTM

Committed revision 40253.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b