Issue 320480043: Fixes ibus-ui-emojier dbus error when print help

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 320480043: Fixes ibus-ui-emojier dbus error when print help

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years ago by Peng Wu

Modified:
7 years ago

Reviewers:
shawn.p.huang, fujiwara

Visibility:
Public.

More Reviews

Description

Fixes ibus-ui-emojier dbus error when print help BUG=

Patch Set 1 #

Total comments: 1

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -0 lines)			Patch
	M	ui/gtk3/emojierapp.vala	View		3 chunks	+12 lines, -0 lines	1 comment	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

fujiwara

It's an interesting patch. Now the dbus error is fixed and ibus-ui-emojier no longer exit ...

7 years ago (2017-04-13 07:10:02 UTC) #2

Peng Wu

On 2017/04/13 07:10:02, fujiwara wrote: > It's an interesting patch. > Now the dbus error ...

7 years ago (2017-04-13 07:35:06 UTC) #3

fujiwara

7 years ago (2017-04-13 07:50:44 UTC) #4

On 2017/04/13 07:35:06, Peng Wu wrote:
> On 2017/04/13 07:10:02, fujiwara wrote:
> > It's an interesting patch.
> > Now the dbus error is fixed and ibus-ui-emojier no longer exit by --help
> option.
> > 
> > 
> > How about adding "ibus emoji exit" option to exit the backend while you
> already
> > add a timeout of it?
> > 
> 
> For unique applications, the unique app needs to send back an dbus reply to
> the second instance.
> 
> Implementing the "ibus emoji exit" command, will bring back the dbus error.

OK, there may be a better fix. Let's leave this CL until we get time.

> 
> > https://codereview.appspot.com/320480043/diff/1/ui/gtk3/emojierapp.vala
> > File ui/gtk3/emojierapp.vala (right):
> > 
> >
>
https://codereview.appspot.com/320480043/diff/1/ui/gtk3/emojierapp.vala#newco...
> > ui/gtk3/emojierapp.vala:28: private IBus.Emojier emojier = new
IBus.Emojier();
> > Today I noticed this.
> > Could you change s/IBus.Emojier emojier/IBus.Emojier m_emojier/ ?
> 
> Fixing it.

Expand All Messages | Collapse All Messages