Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(11)

Issue 320480043: Fixes ibus-ui-emojier dbus error when print help

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 2 days ago by Peng Wu
Modified:
2 weeks, 2 days ago
Reviewers:
shawn.p.huang, fujiwara
Visibility:
Public.

Description

Fixes ibus-ui-emojier dbus error when print help BUG=

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ui/gtk3/emojierapp.vala View 3 chunks +12 lines, -0 lines 1 comment Download

Messages

Total messages: 4
Peng Wu
Please review it, thanks!
2 weeks, 2 days ago (2017-04-13 06:01:16 UTC) #1
fujiwara
It's an interesting patch. Now the dbus error is fixed and ibus-ui-emojier no longer exit ...
2 weeks, 2 days ago (2017-04-13 07:10:02 UTC) #2
Peng Wu
On 2017/04/13 07:10:02, fujiwara wrote: > It's an interesting patch. > Now the dbus error ...
2 weeks, 2 days ago (2017-04-13 07:35:06 UTC) #3
fujiwara
2 weeks, 2 days ago (2017-04-13 07:50:44 UTC) #4
On 2017/04/13 07:35:06, Peng Wu wrote:
> On 2017/04/13 07:10:02, fujiwara wrote:
> > It's an interesting patch.
> > Now the dbus error is fixed and ibus-ui-emojier no longer exit by --help
> option.
> > 
> > 
> > How about adding "ibus emoji exit" option to exit the backend while you
> already
> > add a timeout of it?
> > 
> 
> For unique applications, the unique app needs to send back an dbus reply to
> the second instance.
> 
> Implementing the "ibus emoji exit" command, will bring back the dbus error.

OK, there may be a better fix. Let's leave this CL until we get time.

> 
> > https://codereview.appspot.com/320480043/diff/1/ui/gtk3/emojierapp.vala
> > File ui/gtk3/emojierapp.vala (right):
> > 
> >
>
https://codereview.appspot.com/320480043/diff/1/ui/gtk3/emojierapp.vala#newco...
> > ui/gtk3/emojierapp.vala:28: private IBus.Emojier emojier = new
IBus.Emojier();
> > Today I noticed this.
> > Could you change s/IBus.Emojier emojier/IBus.Emojier m_emojier/ ?
> 
> Fixing it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted