Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(973)

Issue 320370043: ICU ticket #13048: modification to make internal header test pass

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 months, 1 week ago by nrunge
Modified:
3 months, 1 week ago
Reviewers:
andy.heninger
CC:
markus.icu, yoshito_umaoka_us.ibm.com
Base URL:
http://source.icu-project.org/repos/icu/trunk/icu4c
Visibility:
Public.

Description

Changes for internal header checks for ICU 59

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M i18n/dtptngen_impl.h View 1 chunk +2 lines, -0 lines 2 comments Download
M i18n/smpdtfst.h View 1 chunk +1 line, -0 lines 0 comments Download
M io/ufile.h View 1 chunk +2 lines, -0 lines 2 comments Download
M test/hdrtst/testinternalheaders.sh View 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 3
nrunge
3 months, 1 week ago (2017-03-16 20:54:40 UTC) #1
andy.heninger
https://codereview.appspot.com/320370043/diff/1/i18n/dtptngen_impl.h File i18n/dtptngen_impl.h (right): https://codereview.appspot.com/320370043/diff/1/i18n/dtptngen_impl.h#newcode18 i18n/dtptngen_impl.h:18: #include "unicode/udatpg.h" udatpg.h should probably be first, being the ...
3 months, 1 week ago (2017-03-17 20:50:45 UTC) #2
nrunge
3 months, 1 week ago (2017-03-17 21:00:19 UTC) #3
All comments attended to.

https://codereview.appspot.com/320370043/diff/1/i18n/dtptngen_impl.h
File i18n/dtptngen_impl.h (right):

https://codereview.appspot.com/320370043/diff/1/i18n/dtptngen_impl.h#newcode18
i18n/dtptngen_impl.h:18: #include "unicode/udatpg.h"
On 2017/03/17 20:50:45, andy.heninger wrote:
> udatpg.h should probably be first, being the primary header for this file. The
> others can go alphabetically, although ICU is not so fussy about that. 

Done.

https://codereview.appspot.com/320370043/diff/1/io/ufile.h
File io/ufile.h (right):

https://codereview.appspot.com/320370043/diff/1/io/ufile.h#newcode24
io/ufile.h:24: #include <stdio.h>
On 2017/03/17 20:50:45, andy.heninger wrote:
> Move down, below #if !UCONFIG_NO_CONVERSION
> utypes appears before the #if, because it defines the UCONFIG stuff, the rest
> should go below.

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 80a51fa-tainted