Issue 319960043: ui/gtk3: Fix panel CSS format for GTK 3.22

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 319960043: ui/gtk3: Fix panel CSS format for GTK 3.22 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 3 months ago by fujiwara

Modified:
7 years, 3 months ago

Reviewers:
shawn.p.huang, Peng

CC:
shawn.p.huang_gmail.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

ui/gtk3: Fix panel CSS format for GTK 3.22 GtkCssProvider no longer works with the Pango format in GTK 3.22 and need to use the CSS format. BUG=https://github.com/ibus/ibus/issues/1879 Committed: aacf5adbba9b9b34a1ec07005e670d209513fb5b

Patch Set 1 #

Total comments: 4

Patch Set 2 : Updated with message #2 #

Patch Set 3 : Updated with the latest master #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -7 lines)			Patch
	M	ui/gtk3/panel.vala	View	1	2 chunks	+14 lines, -7 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

lgtm with a suggestion. https://codereview.appspot.com/319960043/diff/1/ui/gtk3/panel.vala File ui/gtk3/panel.vala (right): https://codereview.appspot.com/319960043/diff/1/ui/gtk3/panel.vala#newcode554 ui/gtk3/panel.vala:554: string data = data_format.printf(font_family, font_size); ...

7 years, 3 months ago (2017-01-10 14:16:24 UTC) #2

fujiwara

https://codereview.appspot.com/319960043/diff/1/ui/gtk3/panel.vala File ui/gtk3/panel.vala (right): https://codereview.appspot.com/319960043/diff/1/ui/gtk3/panel.vala#newcode554 ui/gtk3/panel.vala:554: string data = data_format.printf(font_family, font_size); On 2017/01/10 14:16:24, Peng ...

7 years, 3 months ago (2017-01-11 03:07:57 UTC) #3

fujiwara

7 years, 3 months ago (2017-01-11 03:17:10 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
aacf5adbba9b9b34a1ec07005e670d209513fb5b (presubmit successful).

Expand All Messages | Collapse All Messages