Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(5191)

Issue 319700043: Support to match emoji annotations with partial string (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 11 months ago by fujiwara
Modified:
6 years, 11 months ago
Reviewers:
shawn.p.huang, Peng Wu, penghuang
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Support to match emoji annotations with partial string Now ibus-setup has a new tab of "Emoji" and it provides the options to choose a condtion and length to match emoji annotations partically. R=alexepico@gmail.com, penghuang@google.com Committed: 0836c3ffd6764969dfaa9953f52a24c1cbf2c983

Patch Set 1 #

Patch Set 2 : Fixed typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+582 lines, -207 lines) Patch
M data/ibus.schemas.in View 1 1 chunk +39 lines, -0 lines 0 comments Download
M setup/main.py View 3 chunks +108 lines, -13 lines 0 comments Download
M setup/setup.ui View 1 15 chunks +311 lines, -180 lines 0 comments Download
M ui/gtk3/emojier.vala View 3 chunks +60 lines, -4 lines 0 comments Download
M ui/gtk3/emojierapp.vala View 3 chunks +42 lines, -10 lines 0 comments Download
M ui/gtk3/panel.vala View 3 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 4
fujiwara
6 years, 11 months ago (2017-04-28 14:02:57 UTC) #1
penghuang
On 2017/04/28 14:02:57, fujiwara wrote: lgtm
6 years, 11 months ago (2017-04-28 14:20:05 UTC) #2
Peng Wu
lgtm
6 years, 11 months ago (2017-05-04 06:37:55 UTC) #3
fujiwara
6 years, 11 months ago (2017-05-05 15:23:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0836c3ffd6764969dfaa9953f52a24c1cbf2c983 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b