Adding output directory support to lab scripts

Adding output directory support to lab scripts

The original version of the lab ETW scripts would only run if the
batch files and scripts were all in the current directory. That's a bug.
And, there was no way of specifying where the output files should go.
This change fixes the bug and allows an optional output directory to be
specified as a parameter to the stop_tracing.bat file. The default
output directory is the current directory.

[brucedawson1, 2017-04-27 18:57:26]

This adds the requested output directory feature. The directory has to be
created ahead of time. It works cleanly in all of my tests.

[crouleau1, 2017-04-27 20:17:29]

LGTM % nits

https://codereview.appspot.com/319690043/diff/1/LabScripts/GeneralTracing/Cre...
File LabScripts/GeneralTracing/CreateExporterConfig.py (right):

https://codereview.appspot.com/319690043/diff/1/LabScripts/GeneralTracing/Cre...
LabScripts/GeneralTracing/CreateExporterConfig.py:24: file.
It would be nice to provide sample usage here and in all files. For this one:

Usage:

python GeneralTracing/CreateExporterConfig.py path/to/trace.etl

https://codereview.appspot.com/319690043/diff/1/LabScripts/GeneralTracing/Cre...
LabScripts/GeneralTracing/CreateExporterConfig.py:35: script_dir =
os.path.split(sys.argv[0])[0]
Instead of 

os.path.split(sys.argv[0])[0]

use

os.path.dirname(sys.argv[0])

https://docs.python.org/2/library/os.path.html#os.path.dirname

https://codereview.appspot.com/319690043/diff/1/LabScripts/GeneralTracing/Rea...
File LabScripts/GeneralTracing/ReadMe.txt (right):

https://codereview.appspot.com/319690043/diff/1/LabScripts/GeneralTracing/Rea...
LabScripts/GeneralTracing/ReadMe.txt:15: the .etl, .csv, and .json files will be
put there.
It would be nice to provide sample usage somewhere in this readme. That will
easily clarify how to provide both "detailed" and output directory to
start_tracing.bat. i.e.:

Usage:

1. Open administer cmd prompt
2. mkdir C:\src\Temp\tempdir
3. path\to\LabScripts\GeneralTracing\start_tracing.bat detailed
4. # do thing and it is traced.
5. path\to\LabScripts\GeneralTracing\stop_tracing.bat C:\src\Temp\tempdir
6. dir C:\src\Temp\tempdir  # formatted data is outputted

[brucedawson1, 2017-04-27 22:06:20]

https://codereview.appspot.com/319690043/diff/1/LabScripts/GeneralTracing/Cre...
File LabScripts/GeneralTracing/CreateExporterConfig.py (right):

https://codereview.appspot.com/319690043/diff/1/LabScripts/GeneralTracing/Cre...
LabScripts/GeneralTracing/CreateExporterConfig.py:24: file.
On 2017/04/27 20:17:28, crouleau1 wrote:
> It would be nice to provide sample usage here and in all files. For this one:
> 
> Usage:
> 
> python GeneralTracing/CreateExporterConfig.py path/to/trace.etl

Done.

https://codereview.appspot.com/319690043/diff/1/LabScripts/GeneralTracing/Cre...
LabScripts/GeneralTracing/CreateExporterConfig.py:35: script_dir =
os.path.split(sys.argv[0])[0]
On 2017/04/27 20:17:29, crouleau1 wrote:
> Instead of 
> 
> os.path.split(sys.argv[0])[0]
> 
> use
> 
> os.path.dirname(sys.argv[0])
> 
> https://docs.python.org/2/library/os.path.html#os.path.dirname

Done.

https://codereview.appspot.com/319690043/diff/1/LabScripts/GeneralTracing/Rea...
File LabScripts/GeneralTracing/ReadMe.txt (right):

https://codereview.appspot.com/319690043/diff/1/LabScripts/GeneralTracing/Rea...
LabScripts/GeneralTracing/ReadMe.txt:15: the .etl, .csv, and .json files will be
put there.
On 2017/04/27 20:17:29, crouleau1 wrote:
> It would be nice to provide sample usage somewhere in this readme. That will
> easily clarify how to provide both "detailed" and output directory to
> start_tracing.bat. i.e.:
> 
> Usage:
> 
> 1. Open administer cmd prompt
> 2. mkdir C:\src\Temp\tempdir
> 3. path\to\LabScripts\GeneralTracing\start_tracing.bat detailed
> 4. # do thing and it is traced.
> 5. path\to\LabScripts\GeneralTracing\stop_tracing.bat C:\src\Temp\tempdir
> 6. dir C:\src\Temp\tempdir  # formatted data is outputted

Done.

[crouleau1, 2017-04-27 22:09:27]

On 2017/04/27 22:06:20, brucedawson1 wrote:
>
https://codereview.appspot.com/319690043/diff/1/LabScripts/GeneralTracing/Cre...
> File LabScripts/GeneralTracing/CreateExporterConfig.py (right):
> 
>
https://codereview.appspot.com/319690043/diff/1/LabScripts/GeneralTracing/Cre...
> LabScripts/GeneralTracing/CreateExporterConfig.py:24: file.
> On 2017/04/27 20:17:28, crouleau1 wrote:
> > It would be nice to provide sample usage here and in all files. For this
one:
> > 
> > Usage:
> > 
> > python GeneralTracing/CreateExporterConfig.py path/to/trace.etl
> 
> Done.
> 
>
https://codereview.appspot.com/319690043/diff/1/LabScripts/GeneralTracing/Cre...
> LabScripts/GeneralTracing/CreateExporterConfig.py:35: script_dir =
> os.path.split(sys.argv[0])[0]
> On 2017/04/27 20:17:29, crouleau1 wrote:
> > Instead of 
> > 
> > os.path.split(sys.argv[0])[0]
> > 
> > use
> > 
> > os.path.dirname(sys.argv[0])
> > 
> > https://docs.python.org/2/library/os.path.html#os.path.dirname
> 
> Done.
> 
>
https://codereview.appspot.com/319690043/diff/1/LabScripts/GeneralTracing/Rea...
> File LabScripts/GeneralTracing/ReadMe.txt (right):
> 
>
https://codereview.appspot.com/319690043/diff/1/LabScripts/GeneralTracing/Rea...
> LabScripts/GeneralTracing/ReadMe.txt:15: the .etl, .csv, and .json files will
be
> put there.
> On 2017/04/27 20:17:29, crouleau1 wrote:
> > It would be nice to provide sample usage somewhere in this readme. That will
> > easily clarify how to provide both "detailed" and output directory to
> > start_tracing.bat. i.e.:
> > 
> > Usage:
> > 
> > 1. Open administer cmd prompt
> > 2. mkdir C:\src\Temp\tempdir
> > 3. path\to\LabScripts\GeneralTracing\start_tracing.bat detailed
> > 4. # do thing and it is traced.
> > 5. path\to\LabScripts\GeneralTracing\stop_tracing.bat C:\src\Temp\tempdir
> > 6. dir C:\src\Temp\tempdir  # formatted data is outputted
> 
> Done.

Could you please upload the new patchset?

git cl upload

[brucedawson1, 2017-04-27 22:12:22]

> git cl upload

It won't let me because I already uploaded the change to github - it's landed
there. Unfortunately landing of changes in UIforETW from rietveld is not
something I've managed to do.

So, grab the changes from github if possible.

[crouleau1, 2017-04-27 22:17:52]

On 2017/04/27 22:12:22, brucedawson1 wrote:
> > git cl upload
> 
> It won't let me because I already uploaded the change to github - it's landed
> there. Unfortunately landing of changes in UIforETW from rietveld is not
> something I've managed to do.
> 
> So, grab the changes from github if possible.

Maybe we should be github UI for reviews instead of rietveld if we can figure
out how to make that work. I'll look into it at some point.

[brucedawson1, 2017-04-27 22:23:19]

> Maybe we should be github UI for reviews instead of rietveld if we can figure
> out how to make that work. I'll look into it at some point.

Yep, that would be good. The process I'm aware of requires cloning the repo for
every change in order to create a pull request. It feels like this adds even
higher friction that the Frankenstein rietveld/git-push model. I've heard that
reusing repos is supposed to work but have not been able to make that happen.
There may be other options.